Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated getfat variables size #420

Merged
merged 2 commits into from
Jul 28, 2021
Merged

Updated getfat variables size #420

merged 2 commits into from
Jul 28, 2021

Conversation

marcsit
Copy link
Contributor

@marcsit marcsit commented Jul 28, 2021

I found a bug in the getfat_c wrapper, concerning the default length for the typelen argument; it is set to 4, that leads to a three letter truncation and ‘SCLK’ is truncated to ‘SCL’.

The correction updates the lenght of the arclen and typlen variables to 5 to accomodate a 4 character string.

Tests have been updated accordingly.

@codecov
Copy link

codecov bot commented Jul 28, 2021

Codecov Report

Merging #420 (e2a25f7) into main (f0550b6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #420   +/-   ##
=======================================
  Coverage   99.87%   99.87%           
=======================================
  Files          12       12           
  Lines       14747    14750    +3     
=======================================
+ Hits        14729    14732    +3     
  Misses         18       18           
Impacted Files Coverage Δ
spiceypy/spiceypy.py 99.69% <100.00%> (ø)
spiceypy/tests/test_wrapper.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0550b6...e2a25f7. Read the comment docs.

@AndrewAnnex
Copy link
Owner

thanks @marcsit! looks good and tests passed so I'll go ahead and merge! :shipit:

@AndrewAnnex AndrewAnnex merged commit d55d849 into AndrewAnnex:main Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants