Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in cartesian planning #68

Merged
merged 1 commit into from
May 10, 2024

Conversation

amalnanavati
Copy link
Contributor

@amalnanavati amalnanavati commented May 7, 2024

My previous PR, #66 , was not thoroughly tested and introduced a bug. This PR resolves that bug, and thoroughly tests it this time. Sorry for overlooking the bug!

Testing

  • Launch the simulated panda arm: ros2 launch panda_moveit_config ex_fake_control.launch.py
  • Verify that the cartesian path service works: ros2 run pymoveit2 ex_pose_goal.py --ros-args -p position:="[0.573, 0.000, 0.488]" -p quat_xyzw:="[1.000, -0.000, 0.001, -0.000]" -p cartesian:=True

@amalnanavati amalnanavati changed the title Fix but in cartesian planning Fix bug in cartesian planning May 7, 2024
Copy link
Owner

@AndrejOrsula AndrejOrsula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@AndrejOrsula AndrejOrsula merged commit 38467ad into AndrejOrsula:devel May 10, 2024
2 checks passed
AndrejOrsula pushed a commit that referenced this pull request May 10, 2024
@amalnanavati amalnanavati deleted the amaln/bugfix branch May 10, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants