Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update msg format to support ROS Iron #49

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

Apurv354
Copy link
Contributor

@Apurv354 Apurv354 commented Feb 22, 2024

There has been an update in the msg format of moveit_msgs mentioned in the CHANGELOG 0.11.3 (2022-09-13) link
It seems like the update in moveit_msgs was not included in the moveit releases until the iron release.
This was causing an error with iron and the current rolling version of moveit:

no member name found cartesian_speed_end_effector_link

I have tested the PR my local and it now works fine in both iron and rolling after updating the msg format.

Given that it seems that the main branch of pymoveit2 is targeting humble, maybe this should be a part of your new release 3.2.0?

Copy link
Owner

@AndrejOrsula AndrejOrsula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for bringing this to my attention!
I have not tried using iron yet. Are you aware of any other breaking changes?

If not, I would try to minimize the effect of this change on the users and simply check if the attribute can be changed.

@@ -1594,7 +1594,7 @@ def __init_move_action_goal(
move_action_goal.request.allowed_planning_time = 0.5
move_action_goal.request.max_velocity_scaling_factor = 0.0
move_action_goal.request.max_acceleration_scaling_factor = 0.0
move_action_goal.request.cartesian_speed_end_effector_link = end_effector
move_action_goal.request.cartesian_speed_limited_link = end_effector
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there are no other breaking changes, I would suggest the following logic in order to minimize the impact on users (NOT TESTED).

Suggested change
move_action_goal.request.cartesian_speed_limited_link = end_effector
# Note: Attribute was renamed in Iron (https://github.com/ros-planning/moveit_msgs/pull/130)
if hasattr(move_action_goal.request, "cartesian_speed_limited_link"):
move_action_goal.request.cartesian_speed_limited_link = end_effector
else:
move_action_goal.request.cartesian_speed_end_effector_link = end_effector

@AndrejOrsula AndrejOrsula changed the base branch from devel to iron_compatibility March 29, 2024 11:14
@AndrejOrsula
Copy link
Owner

Thank you again for your contribution! I will go ahead and merge it into a separate branch first, where I will apply the suggestions from above before merging it into devel.

@AndrejOrsula AndrejOrsula marked this pull request as ready for review March 29, 2024 11:15
@AndrejOrsula AndrejOrsula merged commit bfd5c15 into AndrejOrsula:iron_compatibility Mar 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants