Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new JsonSerializer #165

Merged
merged 7 commits into from
Oct 13, 2024
Merged

Implement new JsonSerializer #165

merged 7 commits into from
Oct 13, 2024

Conversation

AndreasLrx
Copy link
Owner

@AndreasLrx AndreasLrx commented Oct 13, 2024

Description

Implemented a new JsonSerializer, enabled with the new compiler define ECSTASY_SERIALIZER_JSON.
It has almost the same interface as RawSerializer since it is a new ISerializer, but it output json as you may expect by the name.
The json rely on rapidjson library.

Also added an explicit name associated wsith the type info of the IEntityComponentSerializer

Close #164

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

[optional] Minor fixes

Fixed Serializer.updateEntity updating only the first entity component.

Added/updated tests?

  • New tests written
  • Existing tests updated
  • Tests are not required because this is a documentation update
  • I need help with writing tests

@AndreasLrx AndreasLrx force-pushed the feature/164-json-serializer branch from adc9bf3 to 8f9b4b3 Compare October 13, 2024 12:51
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.59%. Comparing base (90fe105) to head (09a915a).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #165   +/-   ##
=======================================
  Coverage   82.59%   82.59%           
=======================================
  Files          64       64           
  Lines        1103     1103           
  Branches      353      353           
=======================================
  Hits          911      911           
  Misses        135      135           
  Partials       57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndreasLrx AndreasLrx force-pushed the feature/164-json-serializer branch from 8f9b4b3 to 4479070 Compare October 13, 2024 13:03
Also fixed Serializer updateEntity and introduced new before/afterUpdate/SaveEntity virtual methods

Linked: #164
@AndreasLrx AndreasLrx force-pushed the feature/164-json-serializer branch from 4479070 to 09a915a Compare October 13, 2024 13:10
@AndreasLrx AndreasLrx merged commit 3a3645a into main Oct 13, 2024
4 checks passed
@AndreasLrx AndreasLrx deleted the feature/164-json-serializer branch October 13, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Implement an optional JsonSerializer
2 participants