Optimizations to logger color pallet

* Created macros to house the default message and tag colors for the logger. This allows reusability by my module and the user; * Changed the logger color pallet to be a static variable;
AndreLaranjeira · Sep 22, 2021 · f88b097 · f88b097
1 parent c12c478
commit f88b097
Show file tree

Hide file tree

Showing 2 changed files with 47 additions and 46 deletions.
diff --git a/include/message_logger.h b/include/message_logger.h
@@ -13,6 +13,50 @@
 #include <time.h>
 
 // Macros:
+#define DEFAULT_LOGGER_MESSAGE_COLORS { \
+  [DEFAULT_MSG] = {                     \
+    .text_color = DFLT,                 \
+    .background_color = DFLT            \
+  },                                    \
+  [ERROR_MSG] = {                       \
+    .text_color = DFLT,                 \
+    .background_color = DFLT            \
+  },                                    \
+  [INFO_MSG] = {                        \
+    .text_color = DFLT,                 \
+    .background_color = DFLT            \
+  },                                    \
+  [SUCCESS_MSG] = {                     \
+    .text_color = DFLT,                 \
+    .background_color = DFLT            \
+  },                                    \
+  [WARNING_MSG] = {                     \
+    .text_color = DFLT,                 \
+    .background_color = DFLT            \
+  }                                     \
+}
+#define DEFAULT_LOGGER_TAG_COLORS { \
+  [CONTEXT_TAG] = {                 \
+    .text_color = B_WHT,            \
+    .background_color = DFLT        \
+  },                                \
+  [ERROR_TAG] = {                   \
+    .text_color = B_RED,            \
+    .background_color = DFLT        \
+  },                                \
+  [INFO_TAG] = {                    \
+    .text_color = B_BLU,            \
+    .background_color = DFLT        \
+  },                                \
+  [SUCCESS_TAG] = {                 \
+    .text_color = B_GRN,            \
+    .background_color = DFLT        \
+  },                                \
+  [WARNING_TAG] = {                 \
+    .text_color = B_YEL,            \
+    .background_color = DFLT        \
+  }                                 \
+}
 #define TIME_FMT_SIZE 50
 
 // Enumerations:

diff --git a/src/message_logger.c b/src/message_logger.c
@@ -6,52 +6,9 @@
 // Private variables:
 static char time_fmt[TIME_FMT_SIZE] = "%H:%M:%S %d-%m-%Y";
 static FILE *log_file = NULL;
-LoggerColorPallet logger_color_pallet = {
-  .message_colors = {
-    [DEFAULT_MSG] = {
-      .text_color = DFLT,
-      .background_color = DFLT
-    },
-    [ERROR_MSG] = {
-      .text_color = DFLT,
-      .background_color = DFLT
-    },
-    [INFO_MSG] = {
-      .text_color = DFLT,
-      .background_color = DFLT
-    },
-    [SUCCESS_MSG] = {
-      .text_color = DFLT,
-      .background_color = DFLT
-    },
-    [WARNING_MSG] = {
-      .text_color = DFLT,
-      .background_color = DFLT
-    },
-  },
-
-  .tag_colors = {
-    [CONTEXT_TAG] = {
-      .text_color = B_WHT,
-      .background_color = DFLT
-    },
-    [ERROR_TAG] = {
-      .text_color = B_RED,
-      .background_color = DFLT
-    },
-    [INFO_TAG] = {
-      .text_color = B_BLU,
-      .background_color = DFLT
-    },
-    [SUCCESS_TAG] = {
-      .text_color = B_GRN,
-      .background_color = DFLT
-    },
-    [WARNING_TAG] = {
-      .text_color = B_YEL,
-      .background_color = DFLT
-    }
-  }
+static LoggerColorPallet logger_color_pallet = {
+  .message_colors = DEFAULT_LOGGER_MESSAGE_COLORS,
+  .tag_colors = DEFAULT_LOGGER_TAG_COLORS
 };
 static pthread_mutex_t *logger_recursive_mutex = NULL;