[BUG] Drop is deemed valuable, when item is not valuable due to display price type conflicts. #1
Labels
bug
Something isn't working
Comments
Anderzenn
added a commit
to Anderzenn/plugin-hub
that referenced
this issue
Nov 3, 2024
- Fixed misspelled link in plugin properties - Fixed bug relating to Anderzenn/valuable-drop-prices#1 - Removed unused code from config - Updated readme & set gradle settings project name to plugins name.
tylerwgrass
pushed a commit
to runelite/plugin-hub
that referenced
this issue
Nov 4, 2024
* Create valuable-drop-prices Simple plugin that replaces the default "coins" value with HA and GE prices to the valuable drop notifications. * Update valuable-drop-prices Updated to be using the correct commit * Update valuable-drop-prices - Fixed misspelled link in plugin properties - Fixed bug relating to Anderzenn/valuable-drop-prices#1 - Removed unused code from config - Updated readme & set gradle settings project name to plugins name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When an item is dropped that has a default value higher than that of the default valuable drop "coins" message, and display price type is set to High Alch. The chat message will write "Valuable drop: item (HA: No Value)".
To Reproduce
Set display price type to high alch, get a drop that has no high alch value but a grand exchange/default value above the set threshold and watch the chat message.
Expected behavior
Instead of writing anything at all, it should simply prevent the message from appearing in the first place.
The text was updated successfully, but these errors were encountered: