-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic scheduling optimizations #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Anders429
added
C - Enhancement
Category: New feature or request.
C - Performance
Category: Related to performance.
P - Low
Priority: Not particularly urgent.
F - rayon
Feature: Parallel processing through the rayon library.
A - Scheduling
Area: Parallel scheduling of systems.
labels
Jan 29, 2023
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## dev #167 +/- ##
==========================================
- Coverage 94.80% 94.23% -0.57%
==========================================
Files 73 75 +2
Lines 10857 11158 +301
==========================================
+ Hits 10293 10515 +222
- Misses 564 643 +79
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A - Scheduling
Area: Parallel scheduling of systems.
C - Enhancement
Category: New feature or request.
C - Performance
Category: Related to performance.
F - rayon
Feature: Parallel processing through the rayon library.
P - Low
Priority: Not particularly urgent.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #73.
This provides dynamic schedule optimizations at runtime. While schedule stages are already defined at compile time according to the views of each task in the schedule, this provides an extra optimization when running the schedule on a specific
World
, namely that it will check whether extra tasks from the next stage can be scheduled alongside the current tasks on that world specifically by keeping track of which component columns are borrowed from which archetypes.When running on
ecs_bench_suite
, I saw a >20% time save on the scheduling test. This is because the optimization actually is applied to that test specifically, due to the last two systems not actually borrowing components from the same archetypes. This is a good performance increase.With a bit of clean up, this is ready to be merged. Will need to fix some lints, add some tests, and update the changelog.