Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Ticket: Escape single quotes in French translation to fix build failure #24

Conversation

wtimme
Copy link
Collaborator

@wtimme wtimme commented Jun 16, 2023

Introduction

The ' need to be escaped (cp. the other translations).
Without the escaping, the build fails.

How to test

  1. Checkout master
  2. Open Android Studio and try to run the app on the emulator

The build will fail and the app will not run.

Now, checkout this pull request's branch and try the same again. The build should succeed.

Additional note

@AndInTheClouds, I would assume that the build fails for the folks over at F-Droid as well, which could also be part of the reason that the new version is not available yet. We probably need to create a new tag.

The `'` need to be escaped (cp. the other translations). Without
the escaping, the build fails.
@AndInTheClouds AndInTheClouds merged commit 52bd5c4 into AndInTheClouds:master Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants