Skip to content

Commit

Permalink
- fix app crash at startup due to minifyEnabled
Browse files Browse the repository at this point in the history
- Prepare release of 2.3.2
  • Loading branch information
AndInTheClouds committed Nov 15, 2024
1 parent d28bf66 commit 2cded98
Show file tree
Hide file tree
Showing 9 changed files with 21 additions and 12 deletions.
4 changes: 1 addition & 3 deletions app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,8 @@ android {
signingConfig signingConfigs.debug

// Enables code shrinking, obfuscation, and optimization
minifyEnabled true
minifyEnabled false

// Enables resource shrinking
shrinkResources true
}
}
lint {
Expand Down
4 changes: 2 additions & 2 deletions app/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
package="org.hollowbamboo.chordreader2"
android:versionCode="11"
android:versionName="2.3.1">
android:versionCode="12"
android:versionName="2.3.2">

<uses-permission android:name="android.permission.INTERNET" />
<uses-permission
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/layout/list_item_setlist_songs.xml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
android:id="@+id/setlist_song_filename_text_view"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_alignEnd="@id/dragHandle"
android:layout_alignEnd="@id/setlist_song_count_text_view"
android:layout_centerVertical="true"
android:layout_toStartOf="@id/setlist_item_delete"
android:layout_toEndOf="@id/setlist_song_count_text_view"
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/values-de/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
<string name="pref_first_run_title">Einführung zurücksetzen</string>
<string name="pref_first_run_summary">Willkommensnachricht nochmal zeigen.</string>
<string name="first_run_title">Willkommen zu Chord Reader 2!</string>
<string name="first_run_message">\n<b>Was ist neu in Version 2.3.0?</b>\n\n\n <li>Akkordvisualisierung für Ukulele</li>\n\n <li>Händigkeitsoptionen für Akkordvisualisierung</li>\n\n <li>Fehlende Akkorde für Visualisierung hinzugefügt</li>\n\n <li>Notennamen Englisch mit Kreuzen hinzugefügt</li>\n\n <li>Verschiedene Fehlerkorrekturen und Verbesserungen</li>\n\n \nChordReader 2 ist eine <b>Open Source Software</b>.</string>
<string name="first_run_message">\n<b>Was ist neu in Version 2.3.2?</b>\n\n\n <li>Akkordvisualisierung für Ukulele</li>\n\n <li>Händigkeitsoptionen für Akkordvisualisierung</li>\n\n <li>Fehlende Akkorde für Visualisierung hinzugefügt</li>\n\n <li>Notennamen Englisch mit Kreuzen hinzugefügt</li>\n\n <li>Verschiedene Fehlerkorrekturen und Verbesserungen</li>\n\n \nChordReader 2 ist eine <b>Open Source Software</b>.</string>
<string name="unsaved_changes">Ungespeicherte Änderungen</string>
<string name="unsaved_changes_message">Möchtest du deine Änderungen speichern?</string>
<string name="closing_chordreader">ChordReader schließen</string>
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/values-es/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
<string name="pref_first_run_title">Restablecer la introducción</string>
<string name="pref_first_run_summary">Mostrar de nuevo el mensaje de introducción.</string>
<string name="first_run_title">Bienvenido/a a Chord Reader 2!</string>
<string name="first_run_message">\n<b>¿Novedades de la versión 2.3.0?</b> \n\n\n <li>Visualización de acordes para ukelele</li>\n\n <li>Opciones de lateralidad para visualización de acordes</li>\n\n <li>Acordes faltantes agregados para visualización</li>\n\n <li>Nombres de notas en inglés con sostenidos agregados</li>\n\n <li>Correcciones de errores varios y mejoras</li>\n\n \nChord Reader 2 es <b>software open source</b>. \n</string>
<string name="first_run_message">\n<b>¿Novedades de la versión 2.3.2?</b> \n\n\n <li>Visualización de acordes para ukelele</li>\n\n <li>Opciones de lateralidad para visualización de acordes</li>\n\n <li>Acordes faltantes agregados para visualización</li>\n\n <li>Nombres de notas en inglés con sostenidos agregados</li>\n\n <li>Correcciones de errores varios y mejoras</li>\n\n \nChord Reader 2 es <b>software open source</b>. \n</string>
<string name="unsaved_changes">Cambios sin guardar</string>
<string name="unsaved_changes_message">¿Quieres guardar tus cambios?</string>
<string name="closing_chordreader">Cerrando ChordReader</string>
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/values-fr/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
<string name="pref_first_run_title">Réinitialiser l\'introduction</string>
<string name="pref_first_run_summary">Montrer de nouveau le message d\'introduction.</string>
<string name="first_run_title">Bienvenue dans Chord Reader 2!</string>
<string name="first_run_message">\n<b>Quoi de neuf dans la version 2.3.0 ?</b>\n\n\n <li>Visualisation des accords pour ukulélé</li>\n\n <li>Options de latéralité pour la visualisation des accords</li>\n\n <li>Accords manquants pour la visualisation ajoutés</li>\n\n <li>Nommage des notes en anglais avec dièses ajoutés</li>\n\n <li>Corrections de bogues diverses et améliorations</li>\n\n \nChord Reader 2 est un <b>logiciel open source</b>.\n</string>
<string name="first_run_message">\n<b>Quoi de neuf dans la version 2.3.2 ?</b>\n\n\n <li>Visualisation des accords pour ukulélé</li>\n\n <li>Options de latéralité pour la visualisation des accords</li>\n\n <li>Accords manquants pour la visualisation ajoutés</li>\n\n <li>Nommage des notes en anglais avec dièses ajoutés</li>\n\n <li>Corrections de bogues diverses et améliorations</li>\n\n \nChord Reader 2 est un <b>logiciel open source</b>.\n</string>
<string name="unsaved_changes">Modifications non enregistrées</string>
<string name="unsaved_changes_message">Voulez-vous enregistrer vos modifications?</string>
<string name="closing_chordreader">Fermeture ChordReader</string>
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
<string name="pref_first_run_title">Reset Introduction</string>
<string name="pref_first_run_summary">Show introductory message again.</string>
<string name="first_run_title">Welcome to Chord Reader 2!</string>
<string name="first_run_message">\n<b>What\'s new in version 2.3.0?</b> \n\n\n <li>Chord visualisation for Ukulele</li>\n\n <li>Handedness options for chord visualisation</li>\n\n <li>Missing chords for visualisation added</li>\n\n <li>Note naming English with sharps added</li>\n\n <li>Miscellaneous bug fixes and improvements</li>\n\n \nChord Reader 2 is <b>open source software</b>. \n</string>
<string name="first_run_message">\n<b>What\'s new in version 2.3.2?</b> \n\n\n <li>Chord visualisation for Ukulele</li>\n\n <li>Handedness options for chord visualisation</li>\n\n <li>Missing chords for visualisation added</li>\n\n <li>Note naming English with sharps added</li>\n\n <li>Miscellaneous bug fixes and improvements</li>\n\n \nChord Reader 2 is <b>open source software</b>. \n</string>
<string name="unsaved_changes">Unsaved Changes</string>
<string name="unsaved_changes_message">Do you want to save your changes?</string>
<string name="closing_chordreader">Closing ChordReader</string>
Expand Down
4 changes: 2 additions & 2 deletions fastlane/metadata/android/en-US/changelogs/10.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
- fixed app crash at startup
- fixed Nextcloud/Network file open error
- Note naming English with sharps added
- switch to searx.work for default search engine
Expand All @@ -8,5 +9,4 @@
- Laterality for chord visualisation added
- ukulele chords added
- fixed unnecessary prompt for zero transposition data in song view
- fixed missing saving of setlist after item removal
- fixed some random app crash
- fixed missing saving of setlist after item removal
11 changes: 11 additions & 0 deletions fastlane/metadata/org.hollowbamboo.chordreader2.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,17 @@ RepoType: git
Repo: https://github.com/AndInTheClouds/chordreader2

Builds:
- - versionName: 2.3.2
versionCode: 12
commit: v2.3.2
subdir: app
sudo:
- apt-get update || apt-get update
- apt-get install -y openjdk-17-jdk-headless
- update-alternatives --auto java
gradle:
- yes

- versionName: 2.3.1
versionCode: 11
commit: v2.3.1
Expand Down

0 comments on commit 2cded98

Please sign in to comment.