Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue so users on Android 10+ can backup to locations other than just phone storage #775

Merged

Conversation

mattschlosser
Copy link
Contributor

A small change... Just moved an if statement... 😄

This change allows users on Android 10+ devices to backup database to locations other than just their phone storage.

Related #756

I think for 3.4, I would add the same two options when backing up modules, so once users have chosen which modules to back up, they would see two options:

  • save to phone storage (use system file picker to save file offline)
  • share (which is currently the default/only option) (used for online sharing)

Describe the pull request content
A clear and concise description of what the pull request is about.
What are the benefits of this new code addition?
Possible negative side effects?

Screenshots
If applicable, add screenshots to help explain your pull request.

@tuomas2
Copy link
Contributor

tuomas2 commented Jul 11, 2020

Your plan for 3.4 sounds good

@tuomas2 tuomas2 merged commit 2f33290 into AndBible:release/v3.3 Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants