-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regex search #3287
Open
JJK96
wants to merge
28
commits into
develop
Choose a base branch
from
regex_search
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Regex search #3287
Changes from 17 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
3d9fe47
Revert "Revert "Add jsword as a submodule""
tuomas2 ce93038
Revert "Revert "Remove references to jsword version""
tuomas2 e58cfdf
Uncleaned version for regex search
JJK96 dff03cf
Add switch for regex search
JJK96 bceda7a
Merge remote-tracking branch 'origin/develop' into regex_search
JJK96 5c1e06a
Merge remote-tracking branch 'origin/develop' into regex_search
JJK96 c5016ae
Merge remote-tracking branch 'origin/develop' into regex_search
JJK96 9161603
Enable Japanese and update JSword
JJK96 65c2efd
Merge remote-tracking branch 'origin/develop' into regex_search
JJK96 14b6a16
Remove db dir since it was removed in develop
JJK96 c8ec62e
This line is now unnecessary because minSdk 26 is the default
JJK96 a13450d
Update jsword
JJK96 36891ac
Merge remote-tracking branch 'origin/develop' into regex_search
JJK96 5b83678
Checkout with submodules to make jsword work
JJK96 0fc893b
Fix bug where regex queries would always search the whole bible
JJK96 92e7283
Rebuild index after Lucene upgrade
JJK96 3f5d910
Merge branch 'current-stable' into regex_search
tuomas2 e1fc57a
Code review fixes
tuomas2 6429c35
Update jsword
tuomas2 4aaae92
Fix similarly also build-apk.yml and jslint.yml as run-tests.yml had …
tuomas2 f314b97
Update java to 21
tuomas2 d92dc82
update jsword
tuomas2 1b62208
update jsword
tuomas2 e3edd02
Change app id for now
tuomas2 0ace870
upgrade jsword
tuomas2 310d6ec
Merge branch 'current-stable' into regex_search
tuomas2 23de811
Update JSword
tuomas2 ba012b2
Merge branch 'develop' into regex_search
tuomas2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
[submodule "jsword"] | ||
path = jsword | ||
url = [email protected]:AndBible/jsword.git |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What requires this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, I'll check what breaks if I put it back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lucene requires this:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is rather conserning in my opinion. We will drop support from very big amount of mobile phones if we drop android 6 and 7. Maybe we need to release two versions, one for old phones and one for new phones if we will merge this...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About 2% of our users are using Android versions 6 / 7 / 7.1.