Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex search #3287

Open
wants to merge 28 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 17 commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
3d9fe47
Revert "Revert "Add jsword as a submodule""
tuomas2 Nov 2, 2023
ce93038
Revert "Revert "Remove references to jsword version""
tuomas2 Nov 2, 2023
e58cfdf
Uncleaned version for regex search
JJK96 Nov 13, 2023
dff03cf
Add switch for regex search
JJK96 Jan 8, 2024
bceda7a
Merge remote-tracking branch 'origin/develop' into regex_search
JJK96 Mar 4, 2024
5c1e06a
Merge remote-tracking branch 'origin/develop' into regex_search
JJK96 May 27, 2024
c5016ae
Merge remote-tracking branch 'origin/develop' into regex_search
JJK96 Jul 8, 2024
9161603
Enable Japanese and update JSword
JJK96 Jul 8, 2024
65c2efd
Merge remote-tracking branch 'origin/develop' into regex_search
JJK96 Aug 5, 2024
14b6a16
Remove db dir since it was removed in develop
JJK96 Aug 5, 2024
c8ec62e
This line is now unnecessary because minSdk 26 is the default
JJK96 Oct 14, 2024
a13450d
Update jsword
JJK96 Oct 14, 2024
36891ac
Merge remote-tracking branch 'origin/develop' into regex_search
JJK96 Oct 14, 2024
5b83678
Checkout with submodules to make jsword work
JJK96 Oct 14, 2024
0fc893b
Fix bug where regex queries would always search the whole bible
JJK96 Oct 14, 2024
92e7283
Rebuild index after Lucene upgrade
JJK96 Oct 14, 2024
3f5d910
Merge branch 'current-stable' into regex_search
tuomas2 Nov 14, 2024
e1fc57a
Code review fixes
tuomas2 Nov 14, 2024
6429c35
Update jsword
tuomas2 Nov 14, 2024
4aaae92
Fix similarly also build-apk.yml and jslint.yml as run-tests.yml had …
tuomas2 Nov 14, 2024
f314b97
Update java to 21
tuomas2 Nov 14, 2024
d92dc82
update jsword
tuomas2 Nov 14, 2024
1b62208
update jsword
tuomas2 Nov 14, 2024
e3edd02
Change app id for now
tuomas2 Nov 14, 2024
0ace870
upgrade jsword
tuomas2 Nov 14, 2024
310d6ec
Merge branch 'current-stable' into regex_search
tuomas2 Jan 9, 2025
23de811
Update JSword
tuomas2 Jan 9, 2025
ba012b2
Merge branch 'develop' into regex_search
tuomas2 Jan 9, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/run-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,10 @@ jobs:
run-unit-tests:
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
fetch-depth: 10 # so that recent tags can be found
submodules: true
- name: Set up JDK
uses: actions/setup-java@v3
with:
Expand Down Expand Up @@ -81,9 +82,10 @@ jobs:
run-instrument-tests:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
fetch-depth: 10 # so that recent tags can be found
submodules: true
- name: Set up JDK
uses: actions/setup-java@v3
with:
Expand Down
3 changes: 3 additions & 0 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[submodule "jsword"]
path = jsword
url = [email protected]:AndBible/jsword.git
7 changes: 3 additions & 4 deletions app/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ val discreteFlavorName = "discrete"
// This value must remain the same as it has been since the original
// release in 2010 for continuity of updates for existing users.
val applicationIdStandard = "net.bible.android.activity"
//val applicationIdStandard = "net.bible.android.activity.next"
// An alternative applicationId, to be used for the "discrete" flavor.
val applicationIdDiscrete = "com.app.calculator"

Expand Down Expand Up @@ -142,7 +143,7 @@ android {
/** these config values override those in AndroidManifest.xml. Can also set versionCode and versionName */
defaultConfig {
applicationId = applicationIdStandard
minSdk = 23
minSdk = 26
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What requires this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, I'll check what breaks if I put it back

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MethodHandle.invoke and MethodHandle.invokeExact are only supported starting with Android O (--min-api 26): Lorg/tartarus/snowball/SnowballProgram;find_among([Lorg/tartarus/snowball/Among;I)I

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lucene requires this:
image

Copy link
Contributor

@tuomas2 tuomas2 Aug 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is rather conserning in my opinion. We will drop support from very big amount of mobile phones if we drop android 6 and 7. Maybe we need to release two versions, one for old phones and one for new phones if we will merge this...

  • I will check and analyze play store statistics.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About 2% of our users are using Android versions 6 / 7 / 7.1.

targetSdk = 34
vectorDrawables.useSupportLibrary = true
buildConfigField("String", "GitHash", "\"${getGitHash()}\"")
Expand Down Expand Up @@ -227,7 +228,6 @@ android {

create("github") {
dimension = dimDistributionChannelName
minSdk = 21
}
}

Expand Down Expand Up @@ -339,7 +339,6 @@ androidComponents {
dependencies {
val commonsTextVersion: String by rootProject.extra
val jdomVersion: String by rootProject.extra
val jswordVersion: String by rootProject.extra
val kotlinVersion: String by rootProject.extra
val coroutinesVersion: String by rootProject.extra
val kotlinxSerializationVersion: String by rootProject.extra
Expand Down Expand Up @@ -405,7 +404,7 @@ dependencies {
implementation("org.apache.commons:commons-lang3:3.12.0") // make sure this is the same version that commons-text depends on
implementation("org.apache.commons:commons-text:$commonsTextVersion")

implementation("com.github.AndBible:jsword:$jswordVersion") {
implementation(project(":jsword")) {
exclude("org.apache.httpcomponents")
}

Expand Down
Loading
Loading