Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transpose the order of the buttons in portrait orientation #1116

Conversation

uniqueid001
Copy link
Contributor

@uniqueid001 uniqueid001 commented May 31, 2021

In portrait orientation, transpose the order of the buttons for
selecting a Bible book, chapter, and verse: lay out the buttons across
the row instead of down the column.

Resolves #142

…tion

In portrait orientation, transpose the order of the buttons for
selecting a Bible book, chapter, and verse:  lay out the buttons across
the row instead of down the column.
@uniqueid001 uniqueid001 force-pushed the bugfix.142-Transpose_Bible-Books-Grid branch from ee84470 to 87977da Compare May 31, 2021 02:11
@uniqueid001 uniqueid001 changed the title \#142: Transpose the order of the buttons in portrait orientation #142: Transpose the order of the buttons in portrait orientation May 31, 2021
@jmarsican
Copy link

jmarsican commented May 31, 2021

Hey @uniqueid001 I wanted to implement the same feature too but @timbze recommended to allow user to toggle traspose books grid with options menu #994 (comment)
So I created issue #1013 and started working on it. It is almost finished and I will create a PR soon ;)

@uniqueid001 uniqueid001 changed the title #142: Transpose the order of the buttons in portrait orientation Transpose the order of the buttons in portrait orientation May 31, 2021
@uniqueid001
Copy link
Contributor Author

uniqueid001 commented May 31, 2021

Okay @jmarsican. I did see that issue, too, but I wanted to start with the easier one : ) Adding a user preference would certainly avoid annoying long-time users who like the vertical arrangement. Your PR can certainly supersede this one, if it will be ready soon.

@tuomas2
Copy link
Contributor

tuomas2 commented May 31, 2021

New PR's should be targeted towards develop branch unless they are important bugfixes to current stable version (and then they should be targeted towards current-stable branch).

@tuomas2
Copy link
Contributor

tuomas2 commented May 31, 2021

Thank you for PR's!

@tuomas2 tuomas2 changed the base branch from release/v3.3 to develop May 31, 2021 07:30
@uniqueid001
Copy link
Contributor Author

New PR's should be targeted towards develop branch unless they are important bugfixes to current stable version (and then they should be targeted towards current-stable branch).

I think this is important : ) I was hoping that this could be included in the next stable update rather than waiting for the next major release. This change can be easily merged onto either branch (notwithstanding its pending mootness). You're welcome for the PRs, and I hope to be able to contribute more.

@tuomas2
Copy link
Contributor

tuomas2 commented Jun 4, 2021

Next version (develop branch) has a lot of important features :-) I try to focus my work so we get new version as soon as possible. And I don't want to change behavior of stable version too much (I'm pretty sure this would cause a lot of complaints by people that have got used to the current behavior).

I'll close in favor of #1122

@tuomas2 tuomas2 closed this Jun 4, 2021
@uniqueid001 uniqueid001 deleted the bugfix.142-Transpose_Bible-Books-Grid branch September 27, 2021 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transpose books of the bible grid to read from left to right.
3 participants