-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transpose the order of the buttons in portrait orientation #1116
Transpose the order of the buttons in portrait orientation #1116
Conversation
…tion In portrait orientation, transpose the order of the buttons for selecting a Bible book, chapter, and verse: lay out the buttons across the row instead of down the column.
ee84470
to
87977da
Compare
Hey @uniqueid001 I wanted to implement the same feature too but @timbze recommended to allow user to toggle traspose books grid with options menu #994 (comment) |
Okay @jmarsican. I did see that issue, too, but I wanted to start with the easier one : ) Adding a user preference would certainly avoid annoying long-time users who like the vertical arrangement. Your PR can certainly supersede this one, if it will be ready soon. |
New PR's should be targeted towards develop branch unless they are important bugfixes to current stable version (and then they should be targeted towards current-stable branch). |
Thank you for PR's! |
I think this is important : ) I was hoping that this could be included in the next stable update rather than waiting for the next major release. This change can be easily merged onto either branch (notwithstanding its pending mootness). You're welcome for the PRs, and I hope to be able to contribute more. |
Next version (develop branch) has a lot of important features :-) I try to focus my work so we get new version as soon as possible. And I don't want to change behavior of stable version too much (I'm pretty sure this would cause a lot of complaints by people that have got used to the current behavior). I'll close in favor of #1122 |
In portrait orientation, transpose the order of the buttons for
selecting a Bible book, chapter, and verse: lay out the buttons across
the row instead of down the column.
Resolves #142