Attempting to go to notes from the menu causes the app to crash

[bvahedy]

In build 370 and 371 I noticed when attempting to access Notes from the menu the app crashes.
I am able to create a note by highlighting the verse and tapping on the pencil icon on top menu.
I'm also able to see the note by tapping on the pencil in the verse and viewing that note. But I'm unable to get a list of notes by going through the main menu ( tap on top left on menu bar then tap on notes)

If you are unable to duplicate this, is it possible that my notes database has been corrupted? If so why would I be able to still create notes.

[bvahedy]

You are right Timmy, I used sqlIte manager and found one entry in the mynotes table with a chapter 0. Once I removed that and reimported the database I was able to go into notes list from the menu. I will close this ticket.

[tuomas2]

Although there is illegal chapter 0 in DB I want to fix this such that there's no crash (but missing entries only).

[tuomas2]

Because #673 might (have) create(d) such illegal entries.

[tuomas2]

This was fixed in 373 as well.

[bvahedy]

Since I removed the chapter 0 entry from my notes database manually I would not be able to test this, but since I can still access my notes through the menu it all seems good and no crash so far. I can try to restore an older database and see if I can test it. Will let you know if I find a problem.

[tuomas2]

You can also edit your database manually to add there chapter 0 entries, to check if this works.

[bvahedy]

Ok, if there are any notes with a chapter 0 the app doesn't crash and it will display the following window every time you try to go to the my note list:

[tuomas2]

@JJK96 was it like this for you?

[JJK96]

Yes, I mentioned this in the pull request, I also mentioned alternatives to this behaviour.

See #699

[timbze]

I think we need to do database migration and remove notes with chapter 0. That would take care of this error. Why leave non-usable data in database?

[tuomas2]

that is ok solution to me. just need full table scan for that.

…

On Sat, Jun 6, 2020, 14:35 Timmy Braun ***@***.***> wrote: I think we need to do database migration and remove notes with chapter 0. That would take care of this error. Why leave non-usable data in database? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#697 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABMK4TM3NCI7IAAY2ELHNLTRVISXFANCNFSM4NTEVVRQ> .

[tuomas2]

Whoever has time can do this :-) I will do this next week if no pull request appears.

[tuomas2]

I now implemented data migration in d585d23. Can someone review the commit?

[tuomas2]

I think I kind of trigger this chapter 0 bug still in one special case:

1. Create my note for Gen.1.0 by long-clicking on first title ("Chapter 1"), on KJV.
   -> there are icon both on both titles as shown in screenshot
2. Click icon on upper title
   -> editor opens chapter 0 note

[timbze]

Should it even be possible to select or make a note for v0? There seems to be no purpose in it as far as I can tell, we probably should not open action mode for v0 at all. I will think on your migration sql a bit more but I think it's the right way to go.

…

On Sat, Jun 6, 2020, 09:07 Tuomas Airaksinen ***@***.***> wrote: I think I kind of trigger this chapter 0 bug still in one special case: 1. Create my note for Gen.1.0 by long-clicking on first title ("Chapter 1"), on KJV. -> there are icon both on both titles as shown in screenshot 2. Click icon on upper title -> editor opens chapter 0 note [image: Screenshot_1591456008] <https://user-images.githubusercontent.com/5811789/83947578-890d6e00-a820-11ea-895a-d74289c021c2.png> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#697 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIL5VSL6OD4TYSLCLB6QMDDRVJLS7ANCNFSM4NTEVVRQ> .

[tuomas2]

you are right, it should not.

…

On Sat, Jun 6, 2020, 18:37 Timmy Braun ***@***.***> wrote: Should it even be possible to select or make a note for v0? There seems to be no purpose in it as far as I can tell, we probably should not open action mode for v0 at all. I will think on your migration sql a bit more but I think it's the right way to go. On Sat, Jun 6, 2020, 09:07 Tuomas Airaksinen ***@***.***> wrote: > I think I kind of trigger this chapter 0 bug still in one special case: > > 1. Create my note for Gen.1.0 by long-clicking on first title > ("Chapter 1"), on KJV. > -> there are icon both on both titles as shown in screenshot > 2. Click icon on upper title > -> editor opens chapter 0 note > > [image: Screenshot_1591456008] > < https://user-images.githubusercontent.com/5811789/83947578-890d6e00-a820-11ea-895a-d74289c021c2.png > > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <#697 (comment) >, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/AIL5VSL6OD4TYSLCLB6QMDDRVJLS7ANCNFSM4NTEVVRQ > > . > — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#697 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABMK4TO7JQOIRWPZAXNAIWDRVJPFPANCNFSM4NTEVVRQ> .

[bvahedy]

Can't duplicate, I'm unable to highlight the chapter title only verse one is selected which is the way it should work. But I'm running beta build 373.

…

On Sat, Jun 6, 2020, 8:07 AM Tuomas Airaksinen ***@***.***> wrote: I think I kind of trigger this chapter 0 bug still in one special case: 1. Create my note for Gen.1.0 by long-clicking on first title ("Chapter 1"), on KJV. -> there are icon both on both titles as shown in screenshot 2. Click icon on upper title -> editor opens chapter 0 note [image: Screenshot_1591456008] <https://user-images.githubusercontent.com/5811789/83947578-890d6e00-a820-11ea-895a-d74289c021c2.png> — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#697 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALCBRMN7YGWX424XNJU4BELRVJLS7ANCNFSM4NTEVVRQ> .

[timbze]

I had to scroll up as far as possible and then long press above the text as high as I could and then was able to reproduce it

…

On Sat, Jun 6, 2020, 10:20 Ben ***@***.***> wrote: Can't duplicate, I'm unable to highlight the chapter title only verse one is selected which is the way it should work. But I'm running beta build 373. On Sat, Jun 6, 2020, 8:07 AM Tuomas Airaksinen ***@***.***> wrote: > I think I kind of trigger this chapter 0 bug still in one special case: > > 1. Create my note for Gen.1.0 by long-clicking on first title > ("Chapter 1"), on KJV. > -> there are icon both on both titles as shown in screenshot > 2. Click icon on upper title > -> editor opens chapter 0 note > > [image: Screenshot_1591456008] > < https://user-images.githubusercontent.com/5811789/83947578-890d6e00-a820-11ea-895a-d74289c021c2.png > > > — > You are receiving this because you modified the open/close state. > Reply to this email directly, view it on GitHub > <#697 (comment) >, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/ALCBRMN7YGWX424XNJU4BELRVJLS7ANCNFSM4NTEVVRQ > > . > — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#697 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIL5VSI7BS74EX6FDW2IKLLRVJUGNANCNFSM4NTEVVRQ> .

[bvahedy]

Ok I tried it with Genesis initial description and I was able to also duplicate this, but the app no longer crashes which is good.

…

On Sat, Jun 6, 2020, 9:32 AM Timmy Braun ***@***.***> wrote: I had to scroll up as far as possible and then long press above the text as high as I could and then was able to reproduce it On Sat, Jun 6, 2020, 10:20 Ben ***@***.***> wrote: > Can't duplicate, I'm unable to highlight the chapter title only verse one > is selected which is the way it should work. But I'm running beta build > 373. > > > On Sat, Jun 6, 2020, 8:07 AM Tuomas Airaksinen ***@***.*** > > wrote: > > > I think I kind of trigger this chapter 0 bug still in one special case: > > > > 1. Create my note for Gen.1.0 by long-clicking on first title > > ("Chapter 1"), on KJV. > > -> there are icon both on both titles as shown in screenshot > > 2. Click icon on upper title > > -> editor opens chapter 0 note > > > > [image: Screenshot_1591456008] > > < > https://user-images.githubusercontent.com/5811789/83947578-890d6e00-a820-11ea-895a-d74289c021c2.png > > > > > > — > > You are receiving this because you modified the open/close state. > > Reply to this email directly, view it on GitHub > > < #697 (comment) > >, > > or unsubscribe > > < > https://github.com/notifications/unsubscribe-auth/ALCBRMN7YGWX424XNJU4BELRVJLS7ANCNFSM4NTEVVRQ > > > > . > > > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <#697 (comment) >, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/AIL5VSI7BS74EX6FDW2IKLLRVJUGNANCNFSM4NTEVVRQ > > . > — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#697 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALCBRMLAAS27ZTKEDKZTZF3RVJVR5ANCNFSM4NTEVVRQ> .

[tuomas2]

With the latest fix, I think we can declare this issue fixed. (build 374)

[bvahedy]

It's still showing me to create a note for verse 0.
If you highlight verse 2 then 1 and then the chapter title. You can then create a note for v0-2 and if you try to go into notes the note will come up empty. But at least no crash happens. I did this in build 374.

[tuomas2]

Fixed in build 375 (Thanks @timbze )