Config entry and various changes #91

edenhaus · 2021-03-09T14:34:36Z

Fixes #77, fixes #69, fixes #31, fixes #80 and in general all configuration.yaml mistakes made from users

Please be aware that even the library changed, https://github.com/And3rsL/Deebotozmo/tree/beta

Create this PR so I can give you feedback here

And3rsL · 2021-03-09T14:49:38Z

To test it:

Download everyting and replace "deebot" in custom components
Remove every reference in configuration.yaml
Integrate it by Settings -> Integrations

No need to save png anywhere. Live map now uses camera component

edenhaus · 2021-03-09T18:36:07Z

I think we should only add translation files, where we actually have already translated the wording. If the file for the specify language doesn't exist, it will fallback automatically to English. This is also the case, when a key doesn't exist in the specific language file and reduce also the maintenance amount, when we introduce a new key. What do you think?

Therefore we would only have the enlgish, italian (which probably you will translate it) and german (which I will translate it)

And3rsL · 2021-03-09T18:39:41Z

Totally agree

edenhaus · 2021-03-09T18:41:01Z

Are all sensor enabled by default? If yes I would disable all by default and the user can then enable the sensor, which he needs. I for example would disable last_clean_image and some stats sensors as I don't need them.

edenhaus · 2021-03-09T18:59:42Z

Logger: homeassistant.util.async_
Source: util/async_.py:129
First occurred: 19:56:30 (4 occurrences)
Last logged: 19:56:30

Detected I/O inside the event loop. This is causing stability issues. Please report issue to the custom component author for deebot doing I/O at custom_components/deebot/config_flow.py, line 49: ecovacs_api = EcoVacsAPI(
Detected I/O inside the event loop. This is causing stability issues. Please report issue to the custom component author for deebot doing I/O at custom_components/deebot/config_flow.py, line 57: return ecovacs_api.devices()

I get the following warnings

Can I also push some changes to this branch?

edenhaus

Nice work. I will test it tomorrow :)

custom_components/deebot/sensor.py

custom_components/deebot/camera.py

custom_components/deebot/sensor.py

add version to manifest and workflow to set it

…istant into beta

edenhaus · 2021-03-10T11:29:31Z

I created the following PR:

add custom integration Deebot for Home Assistant home-assistant/brands#2327 So the ecovacs icon is shown in the integration page
Add deebot custom component home-assistant/wheels-custom-integrations#331

This are requirements for hacs, which I found out,when I was trying to change the name their.

- Unload library on entity delete - No more warnings on sync calls

And3rsL · 2021-03-10T12:01:11Z

I created the following PR:

home-assistant/brands#2327 So the ecovacs icon is shown in the integration page

home-assistant/wheels-custom-integrations#331

This are requirements for hacs, which I found out,when I was trying to change the name their.

i was just wondering how set a integration image! nice!

edenhaus · 2021-03-10T13:28:20Z

I added that all sensors are disabled by default and the user can enable only the sensor, which he needs.

During this change I recognized that we don't setup a device. This would be really helpful, as the user gets a overview of the device with it's corresponding entities, automation's, etc.
See screenshot below from esphome:

What do you think?

custom_components/deebot/sensor.py

Subscribe to water events

custom_components/deebot/helpers.py

edenhaus · 2021-03-10T20:31:25Z

custom_components/deebot/config_flow.py

+                else:
+                    self.data[CONF_DEVICEID] = user_input
+                    return self.async_create_entry(
+                        title="Ecovacs vacuum custom integration", data=self.data


I suggest that we set as title the name of the vacuum. So the user can distinguish the vacuums on the integration side. Currently we create each entry with the same name. For example compare it with EspHome in the screenshot below (esp01, esp02, ... are the device names. I personally called them in this manner)

To get the title correct, we probably should only allow single select on the robots list or create of each selected robot a different entry.

Currently it is also possible to add the same vacuum twice. I think we should throw an error, when the vacuum is already set up.

okay I think I have a idea for the problem. Will give it a try tomorrow

I don't know, i would like have it by account.. insert multiple times same user and password for different robots on same account is kinda confusing

The account is fine for me. Only we should add a OptionHandler, so a user can change room color and co without deleting and creating the entry again

Yes, i agree with that, maybe use first "form" to insert only Username,Password,Country,Continent -> Select robots and then from Options you should choose live map and room colors.. maybe add more options such as map color, line color etc..

At the moment im honestly a bit scared from ecovacs api.. it seems like they started changes endpoints. i hope they dont change it too much

At the moment im honestly a bit scared from ecovacs api.. it seems like they started changes endpoints. i hope they dont change it too much

Not good et all.... Next week I hopefully set up bumper (selfhosted deebot server) so my vacuum is not anymore sending data to china

@And3rsL Since Version 2 of the app ecovacs uses oauth. Probably that was the big api change.
Give a look my PR at bumper bmartin5692/bumper#116
There exists new endpoints like /newauth.do and api/appsvr/oauth_callback which we must probably use in the future.
After calling the oauth_callback each post request has the following in it's body

"auth": { "realm": "ecouser.net", "resource": "IASB481A03G8", "token": "TOKEN", "userid": "USERID", "with": "users" }

edenhaus · 2021-03-11T14:21:54Z

custom_components/deebot/hub.py

+                )
+
+                _LOGGER.debug("New vacbot found: " + device["name"])
+                vacbot.setScheduleUpdates()


We should run this method later in a different thread. This method takes more then 10 seconds to complete.... Think you have more than one robot it can take more then 30 seconds or even more.
I think we should run this method later on in parallel. For testing I comment out this method and the conflig flow was quickly finished. Also I think the user has no problems if the robots is unavailable for a minutes after after creation.

Also setScheduleUpdates has problems, when the vacuum is offline during setup.

I would probably remove this method. See And3rsL/Deebotozmo#27 (comment)

…uicker

And3rsL added 3 commits March 9, 2021 15:06

Config entry and various changes

a4626ff

Update packages to beta channel

76f4bcf

Fixed Leftover

0f72ff1

Translatons and LiveMap Camera!

a5e5c21

No need to save png anywhere. Live map now uses camera component

edenhaus commented Mar 9, 2021

View reviewed changes

custom_components/deebot/sensor.py Outdated Show resolved Hide resolved

edenhaus added 2 commits March 9, 2021 20:25

add version to manifest and workflow to set it

7246eab

subscribe to water events

15e358f

edenhaus commented Mar 9, 2021

View reviewed changes

custom_components/deebot/camera.py Outdated Show resolved Hide resolved

custom_components/deebot/sensor.py Show resolved Hide resolved

And3rsL and others added 6 commits March 10, 2021 09:47

Merge pull request #89 from edenhaus/version

343a007

add version to manifest and workflow to set it

add german translations

4fd1baa

New repo link and readme update

1285043

Merge branch 'beta' of https://github.com/And3rsL/Deebot-for-Home-Ass…

5c288ce

…istant into beta

remove removed field

4ce2227

add hassfest validation

9fa0be5

Unload & warnings fix

87038bb

- Unload library on entity delete - No more warnings on sync calls

disable sensors as default

c8e3973

edenhaus added 2 commits March 10, 2021 14:38

subscribe to the correct event for each sensor

ccc35e8

fix schedule_update_ha_state

9253bc3

edenhaus force-pushed the beta branch from cb5ccd8 to 9253bc3 Compare March 10, 2021 15:01

edenhaus commented Mar 10, 2021

View reviewed changes

custom_components/deebot/sensor.py Outdated Show resolved Hide resolved

edenhaus added 2 commits March 10, 2021 16:05

hass object is required for schedule_update_ha_state

66e4c80

fix copy paste error

ed681e7

edenhaus added 5 commits March 10, 2021 16:16

Merge branch 'beta' into beta-mop

fe3d150

fix schedule_update_ha_state

a0d46a9

Merge pull request #93 from edenhaus/beta-mop

0c3098a

Subscribe to water events

add device info

c4b1cb4

remove camera_image

9042a44

edenhaus commented Mar 10, 2021

View reviewed changes

custom_components/deebot/helpers.py Outdated Show resolved Hide resolved

edenhaus commented Mar 10, 2021

View reviewed changes

Add FWVersion and Model Name

8597c26

edenhaus commented Mar 11, 2021

View reviewed changes

edenhaus and others added 4 commits March 11, 2021 21:11

add event unsubscribe for vacuum

d08f71c

call setScheduleUpdates in separate Task to create the config entry q…

03dc3cd

…uicker

Update hacs.json

467bf47

Merge branch 'master' into beta

09cf828

And3rsL marked this pull request as ready for review April 26, 2021 13:41

And3rsL merged commit 0b2ac39 into master Apr 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Config entry and various changes #91

Config entry and various changes #91

edenhaus commented Mar 9, 2021 •

edited

Loading

And3rsL commented Mar 9, 2021

edenhaus commented Mar 9, 2021

And3rsL commented Mar 9, 2021

edenhaus commented Mar 9, 2021

edenhaus commented Mar 9, 2021 •

edited

Loading

edenhaus left a comment

edenhaus commented Mar 10, 2021 •

edited

Loading

And3rsL commented Mar 10, 2021

edenhaus commented Mar 10, 2021

edenhaus Mar 10, 2021

edenhaus Mar 10, 2021

And3rsL Mar 10, 2021

edenhaus Mar 11, 2021

And3rsL Mar 11, 2021

And3rsL Mar 11, 2021

edenhaus Mar 11, 2021

edenhaus Apr 11, 2021

edenhaus Mar 11, 2021

edenhaus Mar 11, 2021

Config entry and various changes #91

Config entry and various changes #91

Conversation

edenhaus commented Mar 9, 2021 • edited Loading

And3rsL commented Mar 9, 2021

edenhaus commented Mar 9, 2021

And3rsL commented Mar 9, 2021

edenhaus commented Mar 9, 2021

edenhaus commented Mar 9, 2021 • edited Loading

edenhaus left a comment

Choose a reason for hiding this comment

edenhaus commented Mar 10, 2021 • edited Loading

And3rsL commented Mar 10, 2021

edenhaus commented Mar 10, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

edenhaus commented Mar 9, 2021 •

edited

Loading

edenhaus commented Mar 9, 2021 •

edited

Loading

edenhaus commented Mar 10, 2021 •

edited

Loading