Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support TNS reverse record #254

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Support TNS reverse record #254

wants to merge 5 commits into from

Conversation

strange-tns
Copy link

Show users' primary names instead of showing their address on the top-right section and wallet detail.

Example

@vercel
Copy link

vercel bot commented Mar 9, 2022

Someone is attempting to deploy a commit to the Anchor Protocol Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Mar 9, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

anchor-landing – ./landing

🔍 Inspect: https://vercel.com/anchor-protocol/anchor-landing/9Ww8wcpK3ZESxcqJu8YnQSVYbPHU
✅ Preview: https://anchor-landing-git-fork-strange-tns-master-anchor-protocol.vercel.app

@vercel vercel bot temporarily deployed to Preview – anchor-landing March 9, 2022 08:18 Inactive
cosullivan
cosullivan suggested changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@cosullivan cosullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Can you please migrate the useTnsReverseRecord to use react-query via the useQuery hook like the other queries.

You can reference useAncBalanceQuery as an example.

Thanks, Cain.

@vercel vercel bot temporarily deployed to Preview – anchor-landing March 18, 2022 07:29 Inactive
@vercel vercel bot temporarily deployed to Preview – anchor-landing March 18, 2022 07:31 Inactive
@strange-tns strange-tns requested a review from cosullivan March 18, 2022 07:33
@sonarcloud
Copy link

sonarcloud bot commented Apr 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cosullivan cosullivan Awaiting requested review from cosullivan

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@strange-tns @cosullivan