Skip to content

Commit

Permalink
Merge pull request apache#1748: [BEAM-14375] Fix Java Wordcount Dataf…
Browse files Browse the repository at this point in the history
…low postcommit for Gradle 7.4
  • Loading branch information
kennknowles authored May 2, 2022
2 parents c52a5b8 + d419e8a commit e0166e2
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/java_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ jobs:
- name: Run :sdks:java:core:test
uses: ./.github/actions/gradle-command-action
with:
arguments: :sdks:java:core:test
arguments: -p sdks/java/core/ test
- name: Upload test logs for :sdks:java:core:test
uses: actions/upload-artifact@v2
if: always()
Expand All @@ -85,7 +85,7 @@ jobs:
- name: Run :sdks:java:harness:test
uses: ./.github/actions/gradle-command-action
with:
arguments: :sdks:java:harness:test
arguments: -p sdks/java/harness/ test
if: always()
- name: Upload test logs for :sdks:java:harness:test
uses: actions/upload-artifact@v2
Expand All @@ -97,7 +97,7 @@ jobs:
- name: Run :runners:core-java:test
uses: ./.github/actions/gradle-command-action
with:
arguments: :runners:core-java:test
arguments: -p runners/core-java/ test
if: always()
- name: Upload test logs for :runners:core-java:test
uses: actions/upload-artifact@v2
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1787,8 +1787,6 @@ class BeamModulePlugin implements Plugin<Project> {
if (pipelineOptionsString && configuration.runner?.equalsIgnoreCase('dataflow')) {
if (pipelineOptionsString.contains('use_runner_v2')) {
dependsOn ':runners:google-cloud-dataflow-java:buildAndPushDockerContainer'
} else {
project.evaluationDependsOn(":runners:google-cloud-dataflow-java:worker:legacy-worker")
}
}

Expand All @@ -1803,6 +1801,7 @@ class BeamModulePlugin implements Plugin<Project> {
"--region=${dataflowRegion}"
])
} else {
project.evaluationDependsOn(":runners:google-cloud-dataflow-java:worker:legacy-worker")
def dataflowWorkerJar = project.findProperty('dataflowWorkerJar') ?:
project.project(":runners:google-cloud-dataflow-java:worker:legacy-worker").shadowJar.archivePath
allOptionsList.addAll([
Expand Down

0 comments on commit e0166e2

Please sign in to comment.