Skip to content

Commit

Permalink
[BEAM-13118] Use branch for nightly "tag", tags are immutable
Browse files Browse the repository at this point in the history
  • Loading branch information
apilloud committed Oct 29, 2021
1 parent 5e3860a commit 8cdc527
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
16 changes: 8 additions & 8 deletions .github/workflows/build_wheels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -341,8 +341,8 @@ jobs:
- name: List file on Google Cloud Storage Bucket
run: gsutil ls "${{ env.GCP_PATH }}*"

tag_repo_nightly:
name: Tag repo nightly
branch_repo_nightly:
name: Branch repo nightly
needs:
- build_source
- build_wheels
Expand All @@ -355,14 +355,14 @@ jobs:
with:
persist-credentials: false
submodules: recursive
- name: Tag commit
- name: Branch commit
run: |
BRANCH_NAME=${GITHUB_REF##*/}
echo "Tagging ${BRANCH_NAME}"
git tag -f nightly-${BRANCH_NAME} HEAD
- name: Push tags
echo "Updating nightly-${BRANCH_NAME}"
git branch -f nightly-${BRANCH_NAME} HEAD
- name: Push branch
uses: ./.github/actions/github-push-action
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
tags: true
branch: master
force: true
branch: nightly-${{ github.ref }}
2 changes: 1 addition & 1 deletion CI.md
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ Service Account shall have following permissions ([IAM roles](https://cloud.goog
| Build python wheels on linux/macos/windows | Builds python wheels on linux/macos/windows platform with usage of `cibuildwheel` and uploads it to artifacts. Artifacts from release branch are used in release process ( [ `build_release_candidate.sh` ](release/src/main/scripts/build_release_candidate.sh) ) | Yes | Yes | Yes | - |
| Upload python wheels to GCS bucket | Uploads python wheels to GCS bucket for path unique for specific workflow run. Additionally uploads workflow run data. | - | Yes | Yes | Yes |
| List files on Google Cloud Storage Bucket | Lists files on GCS for verification purpose. | - | Yes | Yes | Yes |
| Tag repo nightly | Tag repo with `nightly-master` tag if build python source distribution and python wheels finished successfully. | - | - | Yes | - |
| Branch repo nightly | Branch repo with `nightly-master` if build python source distribution and python wheels finished successfully. | - | - | Yes | - |

#### Python tests - [python_tests.yml](.github/workflows/python_tests.yml)

Expand Down

0 comments on commit 8cdc527

Please sign in to comment.