Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for model color, colorBlendMode, and colorBlendAmount #122

Merged
merged 11 commits into from
Dec 6, 2016

Conversation

lilleyse
Copy link
Contributor

@lilleyse lilleyse commented Dec 6, 2016

Cesium implementation: CesiumGS/cesium#4547

@pjcozzi
Copy link
Contributor

pjcozzi commented Dec 6, 2016

@shunter or @mramato can you please review?

@shunter
Copy link
Member

shunter commented Dec 6, 2016

FYI changing the schema is just the first of several steps in adding things to CZML:

  • Regenerate C#
  • Write tests
  • Translate to Java
  • Regenerate markdown for wiki
  • etc.

Since I'm assuming you don't have access to the network since you're offsite this week, I'll work on this today.

@lilleyse
Copy link
Contributor Author

lilleyse commented Dec 6, 2016

Thanks @shunter.

@lilleyse
Copy link
Contributor Author

lilleyse commented Dec 6, 2016

Actually if you haven't started already, you can wait on this. We have a few other czml changes coming in.

@shunter shunter merged commit 7d9f5db into master Dec 6, 2016
@shunter shunter deleted the model-color branch December 6, 2016 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants