Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching based on a selected value in a custom column? #271

Closed
Numpsy opened this issue Jul 24, 2020 · 11 comments · Fixed by #281
Closed

Searching based on a selected value in a custom column? #271

Numpsy opened this issue Jul 24, 2020 · 11 comments · Fixed by #281
Labels
question Further information is requested

Comments

@Numpsy
Copy link

Numpsy commented Jul 24, 2020

A thought that i had while using the 4.2.4 release (I see there have been some search changes recently, so I don't know what the actual unreleased state is), but I did'nt see an option in this version, so:

Say I have something like this log from an ASP.Net Core app:

image

Where all the log entries have a RequestId property that gets set up by ASP itself.
In this trivial case, all the entries for a request are in a stack, but if there are multiple clients hitting the service at once then you might get the logging for many requests all intermixed.

So - I'm wondering if it would be useful to be able to do something like right click on a cell, and launch a search for all matching values from there (any then use that to get the subset of all events that match that one request)?

@Numpsy Numpsy added the question Further information is requested label Jul 24, 2020
@LiorBanai
Copy link
Member

LiorBanai commented Jul 24, 2020

right now I'm in the process of adding in-place search and filter: #269
also right click currently has hard coded Exclude text,source and process/module:
image

do you mean you wish new options to include / Exclude current Cell: XXX where the value will be added to the include/exclude columns:
image

btw, I'll release version 4.2.5 tomorrow probably with the following release notes:

Bug fixes:

-Exclude source/module/text does not clear the hints text. #259

Improvements/changes:

@Numpsy
Copy link
Author

Numpsy commented Jul 24, 2020

In this example, I'm thinking - right click on a row in the RequestId column, and start a search for the text in that cell (so, search for all logs entries whose RequestId is '0HM...' rather than having to enter the text in the search field manually

@LiorBanai
Copy link
Member

so basically set a filter for that text and in the filtered list start a search/filter:
you can filter most columns by typing a text in the header row:
image

@Numpsy
Copy link
Author

Numpsy commented Jul 24, 2020

I hadn't realised that you could do that :-)

@LiorBanai
Copy link
Member

LiorBanai commented Jul 24, 2020

You can combine both header filters and primary filters. They can work together.

@Numpsy
Copy link
Author

Numpsy commented Jul 26, 2020

So what i'm asking about is just the ability to start a header filter for the text in a selected cell then.

@LiorBanai
Copy link
Member

I don't understand, you cannot type filter in the specific column's header with the cell text?

@Numpsy
Copy link
Author

Numpsy commented Jul 28, 2020

It's a pretty trivial thing, I just thought it'd be easier when searching/filtering on values that aren't particularly 'friendly', e.g.

image

@LiorBanai
Copy link
Member

Ah now I understand. Make the process easier /simplify.. 🙂

@LiorBanai
Copy link
Member

@Numpsy
is this what you meant?
Right click a cell and thre is a new option to add it to active column filter:
image

LiorBanai added a commit that referenced this issue Jul 30, 2020
@LiorBanai LiorBanai linked a pull request Jul 31, 2020 that will close this issue
@Numpsy
Copy link
Author

Numpsy commented Jul 31, 2020

Yes, thanks :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants