Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Google.Protobuf from 3.26.1 to 3.27.0 #227

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -17,7 +17,7 @@
<ItemGroup>
<PackageReference Include="Analogy.LogServer.Clients" Version="6.0.0" />
<PackageReference Include="Analogy.LogViewer.Interfaces" Version="6.0.0.1" />
<PackageReference Include="Google.Protobuf" Version="3.26.1" />
<PackageReference Include="Google.Protobuf" Version="3.27.0" />
<PackageReference Include="Grpc.Net.Client" Version="2.62.0" />
</ItemGroup>
<ItemGroup>

Unchanged files with check annotations Beta

{
public class AnalogyLogger : ILogger
{
private readonly string _name;

Check warning on line 10 in Analogy.AspNetCore.LogProvider/AnalogyLogger.cs

GitHub Actions / build (Release)

Check warning on line 10 in Analogy.AspNetCore.LogProvider/AnalogyLogger.cs

GitHub Actions / build (Debug)

private readonly AnalogyLoggerConfiguration _config;

Check warning on line 11 in Analogy.AspNetCore.LogProvider/AnalogyLogger.cs

GitHub Actions / build (Release)

Check warning on line 11 in Analogy.AspNetCore.LogProvider/AnalogyLogger.cs

GitHub Actions / build (Debug)

private readonly AnalogyMessageProducer logSender;
private bool gRPCEnabled = true;
logSender = producer;
}
public void Log<TState>(LogLevel logLevel, EventId eventId, TState state, Exception exception,

Check warning on line 22 in Analogy.AspNetCore.LogProvider/AnalogyLogger.cs

GitHub Actions / build (Release)

Nullability of reference types in type of parameter 'exception' of 'void AnalogyLogger.Log<TState>(LogLevel logLevel, EventId eventId, TState state, Exception exception, Func<TState, Exception, string> formatter)' doesn't match implicitly implemented member 'void ILogger.Log<TState>(LogLevel logLevel, EventId eventId, TState state, Exception? exception, Func<TState, Exception?, string> formatter)' (possibly because of nullability attributes).

Check warning on line 22 in Analogy.AspNetCore.LogProvider/AnalogyLogger.cs

GitHub Actions / build (Debug)

Nullability of reference types in type of parameter 'exception' of 'void AnalogyLogger.Log<TState>(LogLevel logLevel, EventId eventId, TState state, Exception exception, Func<TState, Exception, string> formatter)' doesn't match implicitly implemented member 'void ILogger.Log<TState>(LogLevel logLevel, EventId eventId, TState state, Exception? exception, Func<TState, Exception?, string> formatter)' (possibly because of nullability attributes).
Func<TState, Exception, string> formatter)
{
if (gRPCEnabled && !IsEnabled(logLevel))
return logLevel >= _config.LogLevel;
}
public IDisposable BeginScope<TState>(TState state)

Check warning on line 80 in Analogy.AspNetCore.LogProvider/AnalogyLogger.cs

GitHub Actions / build (Release)

Nullability in constraints for type parameter 'TState' of method 'AnalogyLogger.BeginScope<TState>(TState)' doesn't match the constraints for type parameter 'TState' of interface method 'ILogger.BeginScope<TState>(TState)'. Consider using an explicit interface implementation instead.

Check warning on line 80 in Analogy.AspNetCore.LogProvider/AnalogyLogger.cs

GitHub Actions / build (Debug)

Nullability in constraints for type parameter 'TState' of method 'AnalogyLogger.BeginScope<TState>(TState)' doesn't match the constraints for type parameter 'TState' of interface method 'ILogger.BeginScope<TState>(TState)'. Consider using an explicit interface implementation instead.
{
return null;

Check warning on line 82 in Analogy.AspNetCore.LogProvider/AnalogyLogger.cs

GitHub Actions / build (Release)

Possible null reference return.

Check warning on line 82 in Analogy.AspNetCore.LogProvider/AnalogyLogger.cs

GitHub Actions / build (Debug)

Possible null reference return.
}
}
}
{
public class AnalogyLoggerProvider : ILoggerProvider
{
private readonly AnalogyLoggerConfiguration _config;

Check warning on line 10 in Analogy.AspNetCore.LogProvider/AnalogyLoggerProvider.cs

GitHub Actions / build (Release)

Check warning on line 10 in Analogy.AspNetCore.LogProvider/AnalogyLoggerProvider.cs

GitHub Actions / build (Debug)

private readonly ConcurrentDictionary<string, AnalogyLogger> _loggers = new ConcurrentDictionary<string, AnalogyLogger>();

Check warning on line 11 in Analogy.AspNetCore.LogProvider/AnalogyLoggerProvider.cs

GitHub Actions / build (Release)

Check warning on line 11 in Analogy.AspNetCore.LogProvider/AnalogyLoggerProvider.cs

GitHub Actions / build (Release)

Use an overload that has a IEqualityComparer<string> or IComparer<string> parameter (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0002.md)

Check warning on line 11 in Analogy.AspNetCore.LogProvider/AnalogyLoggerProvider.cs

GitHub Actions / build (Debug)

Check warning on line 11 in Analogy.AspNetCore.LogProvider/AnalogyLoggerProvider.cs

GitHub Actions / build (Debug)

Use an overload that has a IEqualityComparer<string> or IComparer<string> parameter (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0002.md)
private readonly ConcurrentDictionary<string, AnalogyMessageProducer> _gRPCSenders = new ConcurrentDictionary<string, AnalogyMessageProducer>();

Check warning on line 12 in Analogy.AspNetCore.LogProvider/AnalogyLoggerProvider.cs

GitHub Actions / build (Release)

Check warning on line 12 in Analogy.AspNetCore.LogProvider/AnalogyLoggerProvider.cs

GitHub Actions / build (Release)

Use an overload that has a IEqualityComparer<string> or IComparer<string> parameter (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0002.md)

Check warning on line 12 in Analogy.AspNetCore.LogProvider/AnalogyLoggerProvider.cs

GitHub Actions / build (Debug)

Check warning on line 12 in Analogy.AspNetCore.LogProvider/AnalogyLoggerProvider.cs

GitHub Actions / build (Debug)

Use an overload that has a IEqualityComparer<string> or IComparer<string> parameter (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0002.md)
public AnalogyLoggerProvider(AnalogyLoggerConfiguration config)
{
_config = config;