Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta styling for open graph image #71

Closed
wants to merge 1 commit into from

Conversation

thescientist13
Copy link
Contributor

Related Issue

revert + update to #69

As I am seeing this now in social previews, which at least isn't black, but would like to get the yellow back and only use one image
Screen Shot 2022-10-25 at 14 49 24

Summary of Changes

  1. Re-use existing transparent image
  2. Add a <meta> tag with the primary theme color set

@thescientist13 thescientist13 added the enhancement Improvement to existing feature label Oct 25, 2022
@thescientist13 thescientist13 added this to the Website v1.0 milestone Oct 25, 2022
@thescientist13
Copy link
Contributor Author

Hmm, doesn't seem supported in FF? Will need to rethink this maybe. Maybe I am looking for something else?

@thescientist13 thescientist13 marked this pull request as draft October 25, 2022 18:57
@thescientist13 thescientist13 force-pushed the enhancement/meta-background-color branch from 12ac778 to 127297d Compare October 30, 2022 19:47
@thescientist13
Copy link
Contributor Author

I think all these images had been transparent the whole time, not sure where / when I recall seeing the yellow background. Maybe my own Mandela Effect? 😳

#80 creates a new image with the background color, so I think that is probably the best way to resolve it, that I can think of anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to existing feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant