introduce the AuthenticationError Exception #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commonism
force-pushed
the
authenticate
branch
2 times, most recently
from
05a6004 to
6f6f1b2
Compare
commonism
force-pushed
the
authenticate
branch
2 times, most recently
from
72075f0 to
43c3e16
Compare
adferrand
requested changes
Apr 24, 2021
There was a problem hiding this comment.
This is an excellent idea, and I had in my bag to provide a decent hierarchy of exceptions classes for Lexicon.
To align your contribution with this design, could you move this new AuthenticationError class into a dedicated module, lexicon.exceptions, create also a LexiconError class and make AuthenticationError a subclass of it? This is for the future and to provide ability to create more dedicated errors under a unified class hierarchy.
adferrand
approved these changes
May 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #784, this introduces an Exception which is used to indicate AuthenticationError