chore(ci): migrate to firebase service account #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced the deprecated `FIREBASE_TOKEN` with `FIREBASE_SERVICE_ACCOUNT_JSON` in the release-dev workflow to follow updated Firebase Distribution requirements. This change aligns with best practices and prepares for future Firebase Action updates. Also streamlined the README documentation for GitHub Actions secrets by reformatting the table into a list with improved headings. This enhances readability, especially when editing the file, as whitespace are now removed.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #562 +/- ##
=======================================
Coverage 72.36% 72.36%
=======================================
Files 133 133
Lines 1603 1603
=======================================
Hits 1160 1160
Misses 443 443
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jonasanker
approved these changes
Dec 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #549
Replaced the deprecated
FIREBASE_TOKENwithFIREBASE_SERVICE_ACCOUNT_JSONin the release-dev workflow to follow updated Firebase Distribution requirements. This change aligns with best practices and prepares for future Firebase Action updates.Also streamlined the README documentation for GitHub Actions secrets by reformatting the table into a list with improved headings. This enhances readability, especially when editing the file, as whitespace are now removed.