Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(opening_hours): update every minute; refactor #554

Merged
merged 4 commits into from
Nov 22, 2023
Merged

feat(opening_hours): update every minute; refactor #554

merged 4 commits into from
Nov 22, 2023

Conversation

marfavi
Copy link
Member

@marfavi marfavi commented Nov 21, 2023 •
edited
Loading

  • Fix wrong text representation of opening hours in the indicator.
  • Add minute-wise update feature to the opening hours indicator.
  • Remove 'isOpen' check from cubit as this is a widget's job.
  • Update doc comments in Timeslot entity.

@marfavi
feat: update opening hours every minute; refactor
f993bf1 
- Fix wrong text representation of opening hours in the indicator.
- Add minute-wise update feature to the opening hours indicator.
- Remove 'isOpen' check from cubit as this is a widget's job.
- Update widget with timer functionality.
- Update doc comments in Timeslot entity.
@marfavi marfavi enabled auto-merge (squash) November 21, 2023 09:20
@ghost
Copy link

ghost commented Nov 21, 2023 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov Codecov
Copy link

codecov bot commented Nov 21, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@69db31a). Click here to learn what that means.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #554   +/-   ##
=======================================
  Coverage        ?   72.68%           
=======================================
  Files           ?      133           
  Lines           ?     1596           
  Branches        ?        0           
=======================================
  Hits            ?     1160           
  Misses          ?      436           
  Partials        ?        0
Flag Coverage Δ
unittests 72.68% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marfavi marfavi changed the title feat: update opening hours every minute; refactor feat(opening_hours): update every minute; refactor Nov 21, 2023
@marfavi marfavi disabled auto-merge November 21, 2023 10:32
@marfavi marfavi enabled auto-merge (squash) November 21, 2023 11:03
@marfavi marfavi requested review from fremartini and a team November 21, 2023 11:34
fredpetersen
fredpetersen approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@fredpetersen fredpetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, but otherwise this looks fine to me

lib/features/opening_hours/domain/entities/timeslot.dart Show resolved Hide resolved
@marfavi marfavi merged commit 9db04b1 into main Nov 22, 2023
@marfavi marfavi deleted the stateful-opening-hours branch November 22, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fremartini fremartini fremartini approved these changes

@fredpetersen fredpetersen fredpetersen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marfavi @fremartini @fredpetersen