refactor: load user info before main content flow #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ensures that the user is loaded from the "splash router" before the home page is shown. This means everything below the "home page" widget will have access to a loaded user cubit state. Extracted from #413 and therefore also a prerequesite for that PR.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #528 +/- ##
==========================================
+ Coverage 73.93% 74.18% +0.24%
==========================================
Files 128 128
Lines 1527 1534 +7
==========================================
+ Hits 1129 1138 +9
+ Misses 398 396 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Merged
marfavi
commented
Oct 24, 2023
test initialize() simplify initialize() to reduce cope duplication user cubit state: convert constructor parameters to positional + make constructors const
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ensures that the user is loaded from the "splash router" before the home page is shown.
This means everything below the "home page" widget will have access to a loaded user cubit state.
Extracted from #413 and therefore also a prerequesite for that PR.