Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update directory structure #509

Merged
merged 10 commits into from
Sep 21, 2023
Merged

Update directory structure #509

merged 10 commits into from
Sep 21, 2023

Conversation

fremartini
Copy link
Member

closes #490

@fremartini fremartini requested a review from marfavi September 21, 2023 16:02
@ghost
Copy link

ghost commented Sep 21, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@fremartini fremartini requested a review from a team September 21, 2023 16:04
@fremartini fremartini enabled auto-merge (squash) September 21, 2023 16:04
@fremartini fremartini disabled auto-merge September 21, 2023 16:05
@fremartini fremartini enabled auto-merge (squash) September 21, 2023 16:05
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: -10.06% ⚠️

Comparison is base (1fd284e) 84.27% compared to head (3b9cfcd) 74.22%.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #509       +/-   ##
============================================
- Coverage    84.27%   74.22%   -10.06%     
============================================
  Files          116      127       +11     
  Lines         1164     1521      +357     
============================================
+ Hits           981     1129      +148     
- Misses         183      392      +209     
Flag Coverage Δ
unittests 74.22% <ø> (-10.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
lib/core/api_uri_constants.dart 0.00% <ø> (ø)
lib/core/encode_passcode.dart 100.00% <ø> (ø)
lib/core/errors/failures.dart 68.75% <ø> (ø)
lib/core/external/external_url_launcher.dart 0.00% <ø> (ø)
lib/core/firebase_analytics_event_logging.dart 100.00% <ø> (ø)
lib/core/ignore_value.dart 0.00% <ø> (ø)
lib/core/network/network_request_executor.dart 100.00% <ø> (ø)
lib/core/storage/secure_storage.dart 100.00% <ø> (ø)
lib/core/strings.dart 32.50% <ø> (ø)
lib/core/styles/app_colors.dart 0.00% <ø> (ø)
... and 32 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fremartini fremartini merged commit facb451 into develop Sep 21, 2023
@fremartini fremartini deleted the frem/cubit_naming branch September 21, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure consistent naming for cubits and features
2 participants