Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced minimum duration for reAuth from 1s to 250ms #497

Merged
merged 2 commits into from
Jun 6, 2023

Conversation

TTA777
Copy link
Member

@TTA777 TTA777 commented Jun 6, 2023

No description provided.

@TTA777 TTA777 requested a review from marfavi June 6, 2023 16:38
@ghost
Copy link

ghost commented Jun 6, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #497 (0e79e73) into develop (6a494ad) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 0e79e73 differs from pull request most recent head ae951dc. Consider uploading reports for the commit ae951dc to get more accurate results

@@           Coverage Diff            @@
##           develop     #497   +/-   ##
========================================
  Coverage    76.19%   76.19%           
========================================
  Files          115      115           
  Lines         1218     1218           
========================================
  Hits           928      928           
  Misses         290      290           
Flag Coverage Δ
unittests 76.19% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/utils/reactivation_authenticator.dart 100.00% <100.00%> (ø)

@marfavi marfavi enabled auto-merge (squash) June 6, 2023 17:02
@marfavi marfavi merged commit ce34315 into develop Jun 6, 2023
@marfavi marfavi deleted the fix/reduceThrottleDurationInReAuth branch June 6, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants