Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor environment logic #469

Merged
merged 4 commits into from
May 23, 2023
Merged

refactor environment logic #469

merged 4 commits into from
May 23, 2023

Conversation

fremartini
Copy link
Member

No description provided.

@fremartini fremartini marked this pull request as draft May 23, 2023 17:02
@ghost
Copy link

ghost commented May 23, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@fremartini fremartini marked this pull request as ready for review May 23, 2023 17:53
@fremartini fremartini requested a review from a team May 23, 2023 17:53
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #469 (5e823d2) into develop (7070c6f) will increase coverage by 1.10%.
The diff coverage is 87.50%.

@@             Coverage Diff             @@
##           develop     #469      +/-   ##
===========================================
+ Coverage    66.10%   67.20%   +1.10%     
===========================================
  Files          100      101       +1     
  Lines         1118     1122       +4     
===========================================
+ Hits           739      754      +15     
+ Misses         379      368      -11     
Flag Coverage Δ
unittests 67.20% <87.50%> (+1.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ironment/presentation/cubit/environment_state.dart 80.00% <ø> (ø)
...tures/environment/domain/entities/environment.dart 66.66% <66.66%> (ø)
...ta/datasources/environment_remote_data_source.dart 100.00% <100.00%> (ø)
...ironment/domain/usecases/get_environment_type.dart 100.00% <100.00%> (ø)
...ironment/presentation/cubit/environment_cubit.dart 100.00% <100.00%> (ø)

@fremartini fremartini enabled auto-merge (squash) May 23, 2023 18:10
@fremartini fremartini force-pushed the frem/refactor_environment branch from d84452f to 7f82070 Compare May 23, 2023 18:20
Copy link
Member

@TTA777 TTA777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fremartini fremartini merged commit 1ec4e30 into develop May 23, 2023
@fremartini fremartini deleted the frem/refactor_environment branch May 23, 2023 18:38
@marfavi marfavi mentioned this pull request May 28, 2023
marfavi added a commit that referenced this pull request May 30, 2023
# New features
* show status on receipts (#468)
* show timestamp on receipt list entry (#478)

# Fixes
* Fix showing raw html in error messages (#463)
* fix(tickets): Fix multiple `CoffeeCard`s sharing the same product id (#471)
* fix: Avoid type casting 204 return types from API (#479)
* fix(receipts): Remove purchase receipt view & refactor payment status display (#478)
* Added awaits for useTicket and FetchReceipts (#464)

# Code refactoring and added tests
* test(utils): Improve String.capitalize() and add tests (#472)
* Refactor and test Leaderboard (#443)
* Refactor payment (#465)
* Refactor environment logic (#469)
* refactor(settings): tidy up `settings_page.dart` (#473)
* Restructure settings (#481)
* Refactor and test login (#483)
* refactor and test voucher (#480)
* Refactor and test register (#486)
* Refactor and test products (#482)

# Chores
* chore: update Bloc packages (#475)
* chore: bump flutter required version to 3.10.2 (#476)
* Migrate to Dart 3 and Flutter 3.10.0 (#452)

# Developer related
* migrate to fpdart (#457)
* Install the CodeSee workflow (#467)
* Update README.md to show coverage on develop branch (#484)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants