Version 1.76.0 #6

SC426 · 2024-03-13T23:15:52Z

rust-activation 1.76.0

Destination channel: defaults

Links

Explanation of changes:

Update version and sha256
Linter fixes
Update tests
Change clang deployment target version for osx-64 to 10.12

cbouss

LGTM

skupr-anaconda

It's not typical for m2w64-toolchain # [win] to be in the run section. Because it's a build tool. It's dependencies are:
m2w64-binutils, m2w64-crt-git, m2w64-gcc, m2w64-gcc-ada, m2w64-gcc-fortran, m2w64-gcc-libgfortran, m2w64-gcc-libs, m2w64-gcc-objc, m2w64-headers-git, m2w64-libmangle-git, m2w64-libwinpthread-git, m2w64-make, m2w64-pkg-config, m2w64-tools-git, m2w64-winpthreads-git, msys2-conda-epoch >=20160418

But I'm not familiar with activation scripts

danpetry · 2024-03-14T15:57:40Z

I'm not either, but I think it means that if the activation packages are used in a build environment, they pull in their compilers and other required tools to the build environment too. In other words, the activation packages need the toolchain to run (in a build environment)

cbouss · 2024-03-14T15:58:33Z

It's not typical for m2w64-toolchain # [win] to be in the run section. Because it's a build tool. It's dependencies are: m2w64-binutils, m2w64-crt-git, m2w64-gcc, m2w64-gcc-ada, m2w64-gcc-fortran, m2w64-gcc-libgfortran, m2w64-gcc-libs, m2w64-gcc-objc, m2w64-headers-git, m2w64-libmangle-git, m2w64-libwinpthread-git, m2w64-make, m2w64-pkg-config, m2w64-tools-git, m2w64-winpthreads-git, msys2-conda-epoch >=20160418

But I'm not familiar with activation scripts

It's for rust-gnu only, which is the rust compiler on windows using the msys2 compiler as a backend.
The regular rust package for windows uses msvc.

danpetry · 2024-03-14T16:03:26Z

AFAIU, the activation packages are called <compiler_name>_<platform> and handles the {{ compiler('<compiler_name>') }} jinja function where in cbc.yaml you have

c_compiler:
   - <compiler_name>

And <platform> is defined somewhere else for each platform (in conda maybe?)

And they often set environment variables or config scripts as well as installing the compiler itself

ryanskeith · 2024-03-14T19:24:21Z

I know it may be bothersome but there is a fundamental difference in how we do rust activations versus conda forge. On everything but windows, we create a file but we should just make use of environment variables.

recipe/meta.yaml

anaconda-pkg-build · 2024-03-18T18:05:50Z

Linter check found the following problems:

ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_6354cpztoo/clone` failed. (See above for error) The following problems have been found:

===== ERRORS =====

clone/recipe/meta.yaml:0: output_script_name_default: output "rust_linux-aarch64": Output should not use default script names build.sh/bld.bat.
clone/recipe/meta.yaml:0: output_script_name_default: output "rust_osx-arm64": Output should not use default script names build.sh/bld.bat.
clone/recipe/meta.yaml:0: output_script_name_default: output "rust_linux-s390x": Output should not use default script names build.sh/bld.bat.
clone/recipe/meta.yaml:0: output_script_name_default: output "rust_osx-64": Output should not use default script names build.sh/bld.bat.
clone/recipe/meta.yaml:0: output_script_name_default: output "rust_linux-64": Output should not use default script names build.sh/bld.bat.
clone/recipe/meta.yaml:0: output_script_name_default: output "rust_linux-ppc64le": Output should not use default script names build.sh/bld.bat.
===== Final Report: =====
6 Errors and 0 Warnings were found

anaconda-pkg-build · 2024-03-19T19:21:52Z

Linter check found the following problems:

ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_b26pemeehj/clone` failed. (See above for error) The following problems have been found:

===== ERRORS =====

clone/recipe/meta.yaml:0: output_script_name_default: output "rust_linux-64": Output should not use default script names build.sh/bld.bat.
clone/recipe/meta.yaml:0: output_script_name_default: output "rust_linux-aarch64": Output should not use default script names build.sh/bld.bat.
clone/recipe/meta.yaml:0: output_script_name_default: output "rust_osx-64": Output should not use default script names build.sh/bld.bat.
clone/recipe/meta.yaml:0: output_script_name_default: output "rust_linux-ppc64le": Output should not use default script names build.sh/bld.bat.
clone/recipe/meta.yaml:0: output_script_name_default: output "rust_osx-arm64": Output should not use default script names build.sh/bld.bat.
clone/recipe/meta.yaml:0: output_script_name_default: output "rust_linux-s390x": Output should not use default script names build.sh/bld.bat.
===== Final Report: =====
6 Errors and 0 Warnings were found

…feedstock into v1.76.0

anaconda-pkg-build · 2024-03-20T14:41:07Z

Linter check found the following problems:

ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_340yr43q53/clone` failed. (See above for error) The following problems have been found:

===== ERRORS =====

clone/recipe/meta.yaml:0: output_script_name_default: output "rust_osx-arm64": Output should not use default script names build.sh/bld.bat.
clone/recipe/meta.yaml:0: output_script_name_default: output "rust_linux-aarch64": Output should not use default script names build.sh/bld.bat.
clone/recipe/meta.yaml:0: output_script_name_default: output "rust_linux-ppc64le": Output should not use default script names build.sh/bld.bat.
clone/recipe/meta.yaml:0: output_script_name_default: output "rust_linux-64": Output should not use default script names build.sh/bld.bat.
clone/recipe/meta.yaml:0: output_script_name_default: output "rust_osx-64": Output should not use default script names build.sh/bld.bat.
clone/recipe/meta.yaml:0: output_script_name_default: output "rust_linux-s390x": Output should not use default script names build.sh/bld.bat.
===== Final Report: =====
6 Errors and 0 Warnings were found

anaconda-pkg-build · 2024-03-20T14:41:27Z

Linter check found the following problems:

ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_9bdqo9t0r5/clone` failed. (See above for error) The following problems have been found:

===== ERRORS =====

clone/recipe/meta.yaml:0: output_script_name_default: output "rust_linux-aarch64": Output should not use default script names build.sh/bld.bat.
clone/recipe/meta.yaml:0: output_script_name_default: output "rust_osx-64": Output should not use default script names build.sh/bld.bat.
clone/recipe/meta.yaml:0: output_script_name_default: output "rust_linux-ppc64le": Output should not use default script names build.sh/bld.bat.
clone/recipe/meta.yaml:0: output_script_name_default: output "rust_linux-64": Output should not use default script names build.sh/bld.bat.
clone/recipe/meta.yaml:0: output_script_name_default: output "rust_linux-s390x": Output should not use default script names build.sh/bld.bat.
clone/recipe/meta.yaml:0: output_script_name_default: output "rust_osx-arm64": Output should not use default script names build.sh/bld.bat.
===== Final Report: =====
6 Errors and 0 Warnings were found

SC426 added 8 commits March 13, 2024 15:39

remove --c64le from forge_test

935f02c

update version

49ef5eb

add staging channel

6220d70

update forge_test

c0a85ca

min osx 10.12

c7839b1

add build__config

6e95d36

update forge_test

142bc0b

update recipe

b2372ac

AnacondaRecipes deleted a comment from anaconda-pkg-build Mar 13, 2024

cbouss approved these changes Mar 14, 2024

View reviewed changes

skupr-anaconda reviewed Mar 14, 2024

View reviewed changes

danpetry approved these changes Mar 14, 2024

View reviewed changes

skupr-anaconda approved these changes Mar 15, 2024

View reviewed changes

JeanChristopheMorinPerso reviewed Mar 15, 2024

View reviewed changes

recipe/meta.yaml Outdated Show resolved Hide resolved

recipe cleanup

b008ac5

AnacondaRecipes deleted a comment from anaconda-pkg-build Mar 18, 2024

more cleanup

433790c

AnacondaRecipes deleted a comment from anaconda-pkg-build Mar 18, 2024

SC426 mentioned this pull request Mar 18, 2024

V0.6.2 AnacondaRecipes/y-py-feedstock#4

Merged

move conda_build_config.yaml to expected location

9e03849

SC426 added 2 commits March 20, 2024 08:37

remove staging channel

ef5974a

Merge branch 'v1.76.0' of github.com:AnacondaRecipes/rust-activation-…

2c21900

…feedstock into v1.76.0

SC426 merged commit e8ea4e3 into master Mar 20, 2024
1 of 3 checks passed

SC426 deleted the v1.76.0 branch March 20, 2024 14:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Version 1.76.0 #6

Version 1.76.0 #6

SC426 commented Mar 13, 2024 •

edited by jira bot

Loading

cbouss left a comment

skupr-anaconda left a comment •

edited

Loading

danpetry commented Mar 14, 2024

cbouss commented Mar 14, 2024

danpetry commented Mar 14, 2024 •

edited

Loading

ryanskeith commented Mar 14, 2024

anaconda-pkg-build commented Mar 18, 2024

anaconda-pkg-build commented Mar 19, 2024

anaconda-pkg-build commented Mar 20, 2024

anaconda-pkg-build commented Mar 20, 2024

Version 1.76.0 #6

Version 1.76.0 #6

Conversation

SC426 commented Mar 13, 2024 • edited by jira bot Loading

Links

Explanation of changes:

cbouss left a comment

Choose a reason for hiding this comment

skupr-anaconda left a comment • edited Loading

Choose a reason for hiding this comment

danpetry commented Mar 14, 2024

cbouss commented Mar 14, 2024

danpetry commented Mar 14, 2024 • edited Loading

ryanskeith commented Mar 14, 2024

anaconda-pkg-build commented Mar 18, 2024

anaconda-pkg-build commented Mar 19, 2024

anaconda-pkg-build commented Mar 20, 2024

anaconda-pkg-build commented Mar 20, 2024

SC426 commented Mar 13, 2024 •

edited by jira bot

Loading

skupr-anaconda left a comment •

edited

Loading

danpetry commented Mar 14, 2024 •

edited

Loading