New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update protobuf to 4.23.4 #22

Closed

M-Waszkiewicz-Anaconda wants to merge 10 commits into master from PKG-2542v2

M-Waszkiewicz-Anaconda commented Aug 22, 2023 •

edited

Loading

protobuf >= 4.0.0, required for snowflake dbt

upstream
replaced abseil-cpp git submodule with conda package
replaced jsoncpp git submodule with conda package
replaced gtest git submodule with conda package
removed unnecessary patches
based on CF with small changes/tweaks

anaconda-pkg-build commented Aug 22, 2023

Linter check found the following problems:

The following problems have been found:

ERROR: clone/recipe/meta.yaml:1: patch_must_be_in_build: patch must be in build when source/patches is set.
ERROR: clone/recipe/meta.yaml:48: host_section_needs_exact_pinnings: output "libprotobuf": Packages in host must have exact version pinnings, except python build tools.
ERROR: clone/recipe/meta.yaml:49: host_section_needs_exact_pinnings: output "libprotobuf": Packages in host must have exact version pinnings, except python build tools.
ERROR: clone/recipe/meta.yaml:50: host_section_needs_exact_pinnings: output "libprotobuf": Packages in host must have exact version pinnings, except python build tools.
ERROR: clone/recipe/meta.yaml:130: host_section_needs_exact_pinnings: output "libprotobuf-static": Packages in host must have exact version pinnings, except python build tools.
ERROR: clone/recipe/meta.yaml:131: host_section_needs_exact_pinnings: output "libprotobuf-static": Packages in host must have exact version pinnings, except python build tools.
ERROR: clone/recipe/meta.yaml:132: host_section_needs_exact_pinnings: output "libprotobuf-static": Packages in host must have exact version pinnings, except python build tools.
INFO: clone/recipe/meta.yaml:169: invalid_url: https://developers.google.com/protocol-buffers/ : URL domain redirect developers.google.com -> protobuf.dev
INFO: clone/recipe/meta.yaml:179: invalid_url: https://developers.google.com/protocol-buffers/ : URL domain redirect developers.google.com -> protobuf.dev
WARNING: clone/recipe/meta.yaml:180: documentation_overspecified: Using doc_url and doc_source_url is overspecified
Errors were found

M-Waszkiewicz-Anaconda force-pushed the PKG-2542v2 branch from 94b752f to 92d89c8 Compare

August 23, 2023 10:37

anaconda-pkg-build commented Aug 23, 2023

Linter check found the following problems:

The following problems have been found:

ERROR: clone/recipe/meta.yaml:1: patch_must_be_in_build: patch must be in build when source/patches is set.
ERROR: clone/recipe/meta.yaml:48: host_section_needs_exact_pinnings: output "libprotobuf": Packages in host must have exact version pinnings, except python build tools.
ERROR: clone/recipe/meta.yaml:49: host_section_needs_exact_pinnings: output "libprotobuf": Packages in host must have exact version pinnings, except python build tools.
ERROR: clone/recipe/meta.yaml:50: host_section_needs_exact_pinnings: output "libprotobuf": Packages in host must have exact version pinnings, except python build tools.
ERROR: clone/recipe/meta.yaml:134: host_section_needs_exact_pinnings: output "libprotobuf-static": Packages in host must have exact version pinnings, except python build tools.
ERROR: clone/recipe/meta.yaml:135: host_section_needs_exact_pinnings: output "libprotobuf-static": Packages in host must have exact version pinnings, except python build tools.
ERROR: clone/recipe/meta.yaml:136: host_section_needs_exact_pinnings: output "libprotobuf-static": Packages in host must have exact version pinnings, except python build tools.
INFO: clone/recipe/meta.yaml:173: invalid_url: https://developers.google.com/protocol-buffers/ : URL domain redirect developers.google.com -> protobuf.dev
INFO: clone/recipe/meta.yaml:183: invalid_url: https://developers.google.com/protocol-buffers/ : URL domain redirect developers.google.com -> protobuf.dev
WARNING: clone/recipe/meta.yaml:184: documentation_overspecified: Using doc_url and doc_source_url is overspecified
Errors were found

M-Waszkiewicz-Anaconda force-pushed the PKG-2542v2 branch from 92d89c8 to 50c68f6 Compare

August 24, 2023 09:03

anaconda-pkg-build commented Aug 24, 2023

Linter check found the following problems:

The following problems have been found:

ERROR: clone/recipe/meta.yaml:1: patch_must_be_in_build: patch must be in build when source/patches is set.
ERROR: clone/recipe/meta.yaml:50: host_section_needs_exact_pinnings: output "libprotobuf": Packages in host must have exact version pinnings, except python build tools.
ERROR: clone/recipe/meta.yaml:136: host_section_needs_exact_pinnings: output "libprotobuf-static": Packages in host must have exact version pinnings, except python build tools.
INFO: clone/recipe/meta.yaml:173: invalid_url: https://developers.google.com/protocol-buffers/ : URL domain redirect developers.google.com -> protobuf.dev
INFO: clone/recipe/meta.yaml:183: invalid_url: https://developers.google.com/protocol-buffers/ : URL domain redirect developers.google.com -> protobuf.dev
WARNING: clone/recipe/meta.yaml:184: documentation_overspecified: Using doc_url and doc_source_url is overspecified
Errors were found


          update to 4.23.4

17d9159

M-Waszkiewicz-Anaconda force-pushed the PKG-2542v2 branch from 50c68f6 to 17d9159 Compare

August 24, 2023 09:20

anaconda-pkg-build commented Aug 24, 2023

Linter check found the following problems:

The following problems have been found:

ERROR: clone/recipe/meta.yaml:1: patch_must_be_in_build: patch must be in build when source/patches is set.
ERROR: clone/recipe/meta.yaml:52: host_section_needs_exact_pinnings: output "libprotobuf": Packages in host must have exact version pinnings, except python build tools.
ERROR: clone/recipe/meta.yaml:138: host_section_needs_exact_pinnings: output "libprotobuf-static": Packages in host must have exact version pinnings, except python build tools.
INFO: clone/recipe/meta.yaml:175: invalid_url: https://developers.google.com/protocol-buffers/ : URL domain redirect developers.google.com -> protobuf.dev
INFO: clone/recipe/meta.yaml:185: invalid_url: https://developers.google.com/protocol-buffers/ : URL domain redirect developers.google.com -> protobuf.dev
WARNING: clone/recipe/meta.yaml:186: documentation_overspecified: Using doc_url and doc_source_url is overspecified
Errors were found


          skip IoTest.LargeOutput test

7b9610e

anaconda-pkg-build commented Aug 24, 2023

Linter check found the following problems:

The following problems have been found:

ERROR: clone/recipe/meta.yaml:1: patch_must_be_in_build: patch must be in build when source/patches is set.
ERROR: clone/recipe/meta.yaml:52: host_section_needs_exact_pinnings: output "libprotobuf": Packages in host must have exact version pinnings, except python build tools.
ERROR: clone/recipe/meta.yaml:138: host_section_needs_exact_pinnings: output "libprotobuf-static": Packages in host must have exact version pinnings, except python build tools.
INFO: clone/recipe/meta.yaml:175: invalid_url: https://developers.google.com/protocol-buffers/ : URL domain redirect developers.google.com -> protobuf.dev
INFO: clone/recipe/meta.yaml:185: invalid_url: https://developers.google.com/protocol-buffers/ : URL domain redirect developers.google.com -> protobuf.dev
WARNING: clone/recipe/meta.yaml:186: documentation_overspecified: Using doc_url and doc_source_url is overspecified
Errors were found

anaconda-pkg-build commented Aug 24, 2023

Linter check found the following problems:

The following problems have been found:

ERROR: clone/recipe/meta.yaml:1: patch_must_be_in_build: patch must be in build when source/patches is set.
ERROR: clone/recipe/meta.yaml:53: host_section_needs_exact_pinnings: output "libprotobuf": Packages in host must have exact version pinnings, except python build tools.
ERROR: clone/recipe/meta.yaml:138: host_section_needs_exact_pinnings: output "libprotobuf-static": Packages in host must have exact version pinnings, except python build tools.
INFO: clone/recipe/meta.yaml:175: invalid_url: https://developers.google.com/protocol-buffers/ : URL domain redirect developers.google.com -> protobuf.dev
INFO: clone/recipe/meta.yaml:185: invalid_url: https://developers.google.com/protocol-buffers/ : URL domain redirect developers.google.com -> protobuf.dev
WARNING: clone/recipe/meta.yaml:186: documentation_overspecified: Using doc_url and doc_source_url is overspecified
Errors were found


          try to build on windows

f0cf80e

M-Waszkiewicz-Anaconda force-pushed the PKG-2542v2 branch from ecc9a57 to f0cf80e Compare

August 24, 2023 14:31

anaconda-pkg-build commented Aug 24, 2023

Linter check found the following problems:

The following problems have been found:

ERROR: clone/recipe/meta.yaml:1: patch_must_be_in_build: patch must be in build when source/patches is set.
ERROR: clone/recipe/meta.yaml:53: host_section_needs_exact_pinnings: output "libprotobuf": Packages in host must have exact version pinnings, except python build tools.
ERROR: clone/recipe/meta.yaml:138: host_section_needs_exact_pinnings: output "libprotobuf-static": Packages in host must have exact version pinnings, except python build tools.
INFO: clone/recipe/meta.yaml:175: invalid_url: https://developers.google.com/protocol-buffers/ : URL domain redirect developers.google.com -> protobuf.dev
INFO: clone/recipe/meta.yaml:185: invalid_url: https://developers.google.com/protocol-buffers/ : URL domain redirect developers.google.com -> protobuf.dev
WARNING: clone/recipe/meta.yaml:186: documentation_overspecified: Using doc_url and doc_source_url is overspecified
Errors were found


          build cmake test in release mode

f33a0e0

anaconda-pkg-build commented Aug 24, 2023

Linter check found the following problems:

The following problems have been found:

ERROR: clone/recipe/meta.yaml:1: patch_must_be_in_build: patch must be in build when source/patches is set.
ERROR: clone/recipe/meta.yaml:52: host_section_needs_exact_pinnings: output "libprotobuf": Packages in host must have exact version pinnings, except python build tools.
ERROR: clone/recipe/meta.yaml:137: host_section_needs_exact_pinnings: output "libprotobuf-static": Packages in host must have exact version pinnings, except python build tools.
INFO: clone/recipe/meta.yaml:174: invalid_url: https://developers.google.com/protocol-buffers/ : URL domain redirect developers.google.com -> protobuf.dev
INFO: clone/recipe/meta.yaml:184: invalid_url: https://developers.google.com/protocol-buffers/ : URL domain redirect developers.google.com -> protobuf.dev
WARNING: clone/recipe/meta.yaml:185: documentation_overspecified: Using doc_url and doc_source_url is overspecified
Errors were found

M-Waszkiewicz-Anaconda force-pushed the PKG-2542v2 branch 2 times, most recently from 3cfbe16 to 0499a4b Compare

August 24, 2023 20:46


          satisfy linter

6db812a

M-Waszkiewicz-Anaconda force-pushed the PKG-2542v2 branch from 0499a4b to 6db812a Compare

August 24, 2023 20:57

JeanChristopheMorinPerso reviewed

View reviewed changes

recipe/meta.yaml Outdated Show resolved Hide resolved

recipe/meta.yaml Show resolved Hide resolved

recipe/meta.yaml Show resolved Hide resolved


          address review comments

a2084e2

M-Waszkiewicz-Anaconda force-pushed the PKG-2542v2 branch from 20f6324 to a2084e2 Compare

August 24, 2023 23:14

M-Waszkiewicz-Anaconda added 3 commits

August 25, 2023 01:49


          add zstd

4d9b388


          move zstd to test requires

34222f3


          add some comments

3eabd44

skupr-anaconda approved these changes

View reviewed changes

skupr-anaconda left a comment

LGTM

skupr-anaconda reviewed

View reviewed changes

recipe/meta.yaml

-                      # One exception was that 3.6.1 was incompatible with 3.6.0
-                      - {{ pin_subpackage('libprotobuf', max_pin='x.x') }}
+                      # protobuf now (intentionally) increments the SOVER with every patch release, which
+                      # breaks tools like grpc_plugin_cpp if they get the wrong libprotoc at runtime, see

skupr-anaconda Aug 28, 2023

Should we additionally test such (and other) downstream packages to verify that they can be built fine?
My thoughts are directed by this major version bump...

Author

M-Waszkiewicz-Anaconda Aug 28, 2023

yes, doing it now, will push on the same channel

boldorider4 reviewed

View reviewed changes

recipe/meta.yaml Show resolved Hide resolved

M-Waszkiewicz-Anaconda commented

View reviewed changes

recipe/cmake_test/CMakeLists.txt Show resolved Hide resolved

JeanChristopheMorinPerso approved these changes

View reviewed changes

boldorider4 approved these changes

View reviewed changes

boldorider4 left a comment

LGTM

ryanskeith approved these changes

View reviewed changes

ryanskeith left a comment

These all look reasonable to me.

ViridianMelody closed this

ViridianMelody reopened this

ViridianMelody closed this

ViridianMelody reopened this

M-Waszkiewicz-Anaconda closed this

M-Waszkiewicz-Anaconda reopened this

M-Waszkiewicz-Anaconda mentioned this pull request

add testing binaries AnacondaRecipes/abseil-cpp-feedstock#8

Merged


          Update abs.yaml to protobuf423 channel

M-Waszkiewicz-Anaconda closed this

M-Waszkiewicz-Anaconda reopened this

M-Waszkiewicz-Anaconda closed this

M-Waszkiewicz-Anaconda reopened this

M-Waszkiewicz-Anaconda closed this

M-Waszkiewicz-Anaconda reopened this

cbouss closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet