Preview home fix #58
Preview home fix #58
Conversation
| @@ -1691,6 +1691,11 @@ static void do_blocking_move_to(float x, float y, float z, float feed_rate = 0.0 | |||
| feedrate = old_feedrate; | |||
| } | |||
|
|
|||
| inline void do_blocking_move_to_axis(AxisEnum axis, float where, float feed_rate = 0.0) { | |||
There was a problem hiding this comment.
Wouldn't it make sense to be do_blocking_axis_move_to() ?
There was a problem hiding this comment.
Wouldn't it make sense to be do_blocking_axis_move_to() ?
No, not to me.
_to() could be _to_xyz()
_to_x()
_to_y()
_to_xy()
_to_z()
_to_axis()
There was a problem hiding this comment.
Isn't the "axis moving to" ?
What is the difference between do_blocking_axis_move_to() and do_blocking_move_to() ? You want to have a single function that allows you to move axis to a coordinate vs the need to call multiple functions, each one for each axis.
From a semantics standpoint the correct term is what Scott said "do_blocking_move_axis_to", from a "sorting/grouping" standpoint yours could make sense.
There was a problem hiding this comment.
After this, another audit of the move functions and what calls them, to see what they all actually, ultimately do from each place. Some unrolling might be possible then.
There was a problem hiding this comment.
From a semantics standpoint
I kind-of get it. You're moving to_x or to_y and those are axes, so in to_axis the term axis stands in for x, y, or z. So… how about do_blocking_move_to_axis_pos, or…
do_blocking_move_to_axis_positiondo_blocking_move_on_given_axis_to_given_positiondo_blocking_move_to_axis_pos_updating_current_position
There was a problem hiding this comment.
If you want to review the func names I would say let's keep them as they are and do this exercise then.. in fact we already discussed about grouping all the into a new Movement object or we could use the existing Nozzle..
Nozzle::move_to_x(), Nozzle::move_to_axis() and so on.
PS: Or maybe rename Nozzle to Tool.. dunno.
There was a problem hiding this comment.
All kinds of possibilities, to be sure! All I know is in the long run it's going to get less ugly. This is a lot like unraveling spaghetti.
There was a problem hiding this comment.
After 25 years of kite flying i know how to untangle kite lines. Software is more complicated. :-)
|
MarlinFirmware#4338 is ready to go. |
No description provided.