Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could you please add support for Swinir Large model and Real Hat Sharper? #54

Open
zelenooki87 opened this issue Aug 22, 2023 · 3 comments

Comments

@zelenooki87
Copy link

https://github.com/XPixelGroup/HAT
https://github.com/JingyunLiang/SwinIR

please, please?

@WolframRhodium
Copy link
Contributor

WolframRhodium commented Aug 22, 2023

  • These models are very slow (significantly slower than waifu2x.swin_unet_*), even with TRT backend.
  • These models are also poorly supported by various backends. With dynamic shapes, TRT usually reports internal error. Naive fp16 quantization affects accuracy.

As a result, these models are not included in built-in models. What's more, other transformer models may have already surpassed them in terms of reconstruction quality (e.g. vs-grlir, SRFormer).

@zelenooki87
Copy link
Author

I am using Hybrid developer version with vsmlrt addon. Could you please share vs-grlir or SRFormer onnx models, if vsmlrt supports them? thanks you very much.

@WolframRhodium
Copy link
Contributor

I don't have these models for sharing, sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants