Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Rename and document common tokens for links #1870

Merged
merged 16 commits into from
Feb 14, 2025

Conversation

alimpens
Copy link
Contributor

Describe the pull request

Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.

What

It renames ams-link-appearance to ams-links and documents these tokens.

Why

It's a better name, and we didn't document these tokens yet.

How

Rename, find and replace, write.

Checklist

Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:

  • Add or update unit tests
  • Add or update documentation
  • Add or update stories
  • Add or update exports in index.* files
  • Start the PR title with a Conventional Commit prefix, as explained here.

@alimpens alimpens requested a review from a team as a code owner February 14, 2025 10:04
@github-actions github-actions bot temporarily deployed to demo-DES-1082-update-links-tokens February 14, 2025 10:05 Destroyed
@alimpens alimpens requested review from dlnr and RubenSibon February 14, 2025 10:05
@github-actions github-actions bot temporarily deployed to demo-DES-1082-update-links-tokens February 14, 2025 13:42 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-1082-update-links-tokens February 14, 2025 13:47 Destroyed
Co-authored-by: Vincent Smedinga <[email protected]>
@github-actions github-actions bot temporarily deployed to demo-DES-1082-update-links-tokens February 14, 2025 15:00 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-1082-update-links-tokens February 14, 2025 15:09 Destroyed
@VincentSmedinga VincentSmedinga changed the title feat!: Rename and document common links tokens feat!: Rename and document common tokens for links Feb 14, 2025
@VincentSmedinga VincentSmedinga enabled auto-merge (squash) February 14, 2025 15:12
@VincentSmedinga VincentSmedinga merged commit 551743d into develop Feb 14, 2025
7 checks passed
@VincentSmedinga VincentSmedinga deleted the feat/DES-1082-update-links-tokens branch February 14, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants