feat(Tabs): Emit the id of an activated Tab Panel #1854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
demo-DES-1168-tabs-change-event
dlnr
reviewed
Feb 7, 2025
github-actions
bot
temporarily deployed
to
demo-DES-1168-tabs-change-event
alimpens
reviewed
Feb 10, 2025
github-actions
bot
temporarily deployed
to
demo-DES-1168-tabs-change-event
github-actions
bot
temporarily deployed
to
demo-DES-1168-tabs-change-event
github-actions
bot
temporarily deployed
to
demo-DES-1168-tabs-change-event
VincentSmedinga
commented
Feb 11, 2025
| @@ -15,10 +15,12 @@ import { useKeyboardFocus } from '../common/useKeyboardFocus' | |||
| export type TabsProps = { | |||
| /** The number of the active tab. Corresponds to its `tab` value. */ | |||
| activeTab?: number | |||
| /* Provides the id of the activated tab. */ | |||
| onChange?: (tabId: number) => void | |||
There was a problem hiding this comment.
Should the callback include the event, as requested? I’m not sure how to achieve that.
There was a problem hiding this comment.
That's not really necessary imo. The Button onClick handler returns the event, so you can access it if you need it.
alimpens
reviewed
Feb 11, 2025
| @@ -15,10 +15,12 @@ import { useKeyboardFocus } from '../common/useKeyboardFocus' | |||
| export type TabsProps = { | |||
| /** The number of the active tab. Corresponds to its `tab` value. */ | |||
| activeTab?: number | |||
| /* Provides the id of the activated tab. */ | |||
| onChange?: (tabId: number) => void | |||
There was a problem hiding this comment.
That's not really necessary imo. The Button onClick handler returns the event, so you can access it if you need it.
Co-authored-by: Aram <[email protected]>
github-actions
bot
temporarily deployed
to
demo-DES-1168-tabs-change-event
github-actions
bot
temporarily deployed
to
demo-DES-1168-tabs-change-event
github-actions
bot
temporarily deployed
to
demo-DES-1168-tabs-change-event
alimpens
approved these changes
Feb 11, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.
What
This adds an
onChangecallback toTabsthat emits the id of a newly activated Tab Panel. Addresses #1846.Why
Applications can use this information, e.g. to store which Tab is active.
How
Added an
onChangeprop and call the provided function after updating the active Tab id.Checklist
Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:
Additional notes