-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Tabs): Execute click handler on Button #1847
Merged
alimpens
merged 4 commits into
release/v0.14.1
from
fix/DES-1164-tabs-button-mouse-event-target
Feb 11, 2025
Merged
fix(Tabs): Execute click handler on Button #1847
alimpens
merged 4 commits into
release/v0.14.1
from
fix/DES-1164-tabs-button-mouse-event-target
Feb 11, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlnr
previously approved these changes
Feb 3, 2025
2ebb4f6
to
13fec92
Compare
RubenSibon
approved these changes
Feb 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; one comment about the wildcard CSS selector.
alimpens
reviewed
Feb 10, 2025
This reverts commit 4c87a51.
alimpens
approved these changes
Feb 11, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.
What
Disallows children of a
Tabs.Button
to become the target of pointer events.Why
To ensure the click event always returns the button as its target.
How
Through CSS.
Checklist
Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:
Additional notes
onClick: (e: MouseEvent<HTMLElement>) => console.log('e.target:', e.target)
to theargs
of the Tabs stories while importingMouseEvent
from React.