Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Accordion): Increase text size for Heading to level 4 #1837

Merged
merged 5 commits into from
Feb 7, 2025

Conversation

VincentSmedinga
Copy link
Contributor

Describe the pull request

Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.

What

Lets an Accordion Heading use Text Level 4 instead of 5.

Why

To make it look like an actual heading.

How

Updating tokens ✨

Checklist

Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:

  • Add or update unit tests
  • Add or update documentation
  • Add or update stories
  • Add or update exports in index.* files
  • Start the PR title with a Conventional Commit prefix, as explained here.

Additional notes

  • None!

@VincentSmedinga VincentSmedinga requested a review from a team as a code owner January 30, 2025 08:32
@VincentSmedinga VincentSmedinga changed the title feat(Accordion): Increase font size for heading feat(Accordion): Increase text size for heading Jan 30, 2025
dlnr
dlnr previously approved these changes Jan 30, 2025
Copy link
Contributor

@dlnr dlnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change!

@github-actions github-actions bot temporarily deployed to demo-DES-1151-accordion-heading-size January 31, 2025 15:29 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-1151-accordion-heading-size January 31, 2025 17:28 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-1151-accordion-heading-size February 7, 2025 09:50 Destroyed
@VincentSmedinga VincentSmedinga changed the title feat(Accordion): Increase text size for heading feat(Accordion): Increase text size for Heading to level 4 Feb 7, 2025
@VincentSmedinga VincentSmedinga enabled auto-merge (squash) February 7, 2025 09:50
@VincentSmedinga VincentSmedinga merged commit 1e914c9 into develop Feb 7, 2025
7 checks passed
@VincentSmedinga VincentSmedinga deleted the feat/DES-1151-accordion-heading-size branch February 7, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants