🚀 [Feature] Disable new signups through server controlled feature flags #1922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…S and DISABLE_EMAIL_AUTH, renamed STORAGE_SKIP_BUCKET_CHECK
1 task
☁️ Nx Cloud ReportCI is running/has finished running commands for commit bf498b5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
AmruthPillai
deleted the
1592-feature-the-possibility-to-disable-new-sign-ups
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1592
This PR contains changes in the environment variables to move them from VITE client side feature flags which were only set during build time, to access them from the server and pass them down to the client so they can be modified on-the-fly.
The two new feature flags are:
Setting
DISABLE_SIGNUPSto true would make the Register page display this banner:Setting
DISABLE_EMAIL_AUTHto true would make the Login page display this banner:Also, the flag
SKIP_STORAGE_BUCKET_CHECKhas been renamed toSTORAGE_SKIP_BUCKET_CHECK, to clearly indicate that it's not a feature flag but just a server configuration that should not be exposed to the client.