fix(docker): add environment variable for puppeteer to launch with ignoreHTTPSerrors flag
#1899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nore http errors flag
1 task
|
Looks really good, I can instantly approve :) Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1897
Add environment variable
CHROME_IGNORE_HTTPS_ERRORSfor puppeteer to launch with flagignoreHTTPSerrors(defaults tofalsefor keep existing behavior).I've tested this by building the image locally and passing
CHROME_IGNORE_HTTPS_ERRORSto the reactive resume container. Setting it totruewill now work again and generate previews correctly.