[Feature] Keyboard Shortcut for Hyperlink #1729
Conversation
Will allow code changes in a subsequent commit to access the function and utilize the same core logic
Use the conventional Ctrl+K keyboard shortcut for adding a hyperlink
| const setLink = useCallback(() => { | ||
| const previousUrl = editor.getAttributes("link").href; | ||
| const url = window.prompt("URL", previousUrl); | ||
| const setLinkGlobal = (editor: Editor) => { |
There was a problem hiding this comment.
I'm open to changing the naming of this function if desired, I just decided to leave Toolbar.setLink as-is to keep the diff of this PR low for now.
There was a problem hiding this comment.
I actually don't mind if the code is refactored to be inside Toolbar, and within a useCallback. Would be neater that way. I can take it from here and make the necessary changes.
Thank you for this quick helpful fix.
| return { | ||
| "Mod-k": () => { | ||
| setLinkGlobal(this.editor as Editor); | ||
| return true; |
There was a problem hiding this comment.
addKeyboardShortcuts expects functions in this object to return a boolean
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 219e699. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
#1728
The Rich Text Editor already has common keyboard shortcuts such as:
Mod-B: BoldMod-I: ItalicsMod-U: Underline(Where
Modis the term used to refer tocmdforMacdevices, andCtrlfor all others in the Tiptap documentation)This PR adds
Mod-Kfor adding a hyperlink when using the Rich Text Editor