Type Error in Picture Configuration Options

[Nikhil-Singhal-06]

Is there an existing issue for this?

• Yes, I have searched the existing issues and none of them match my problem.

Product Variant

Cloud (https://rxresu.me)

Current Behavior

In the Basics section, under the picture configuration options, when a user clicks on the already selected aspect ratio or border radius, a type error is thrown.

Expected Behavior

The application should simply recognize the selection as already active and maintain the current state.

Steps To Reproduce

No response

What browsers are you seeing the problem on?

Chrome

What template are you using?

None

Anything else?

No response

[DemaPy]

@AmruthPillai Hi, I found where problem lies.
You just have to add additional check if value is toggled.
If user click on the same value aspect ratio again, value will be empty string,

Currently selected: 0.75 which is portrait.
Which is result undefined here;
const stringToRatioMap = { square: 1, portrait: 0.75, horizontal: 1.33, } as const;
const onAspectRatioChange = (value: AspectRatio) => { setValue("basics.picture.aspectRatio", stringToRatioMap[value]); };

Also I found another one issue with input, for aspect ratio. When input is empty. (Patch request failed every time when user clear input to change aspect ratio)

[DemaPy]

@AmruthPillai I have created pull request: #1909