Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gamepad for egui And updating deps #45

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Conversation

Amjad50
Copy link
Owner

@Amjad50 Amjad50 commented Nov 12, 2024

Fixes #5

This also has additionally:

  • Don't panic if we can't initialize audio in the egui ui, and just disable audio. For now we don't display errors, but this could be a nice improvement to add later.
  • Update deps
  • Made all packages (UIs) 0.3.4 to prepare for next release (skipping 0.3.2 and 0.3.3)

This is better for when releasing new release later

Signed-off-by: Amjad Alsharafi <[email protected]>
And also gracefully handle issues on initializing audio

Signed-off-by: Amjad Alsharafi <[email protected]>
Signed-off-by: Amjad Alsharafi <[email protected]>
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.81%. Comparing base (24f3747) to head (ec9c991).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #45   +/-   ##
=======================================
  Coverage   81.81%   81.81%           
=======================================
  Files          37       37           
  Lines        5352     5352           
=======================================
  Hits         4379     4379           
  Misses        973      973           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Amjad50 Amjad50 merged commit f8b2c61 into master Nov 12, 2024
4 checks passed
@Amjad50 Amjad50 deleted the gamepad_for_egui_and_updates branch November 12, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement controller support for the new UI
1 participant