ATK-1309 Import GlobalBrandsHeader into pantry #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| renderUser() { | ||
| const { deviceType, includeAccount, user } = this.props; | ||
| const favorites = messages.favorites; | ||
| const classNames = 'global-header-account__link button tomato'; |
There was a problem hiding this comment.
let's see if we can strip the tomato references from here - Maybe a default style for this button in the associated style sheet that references the hex variable name. Putting the tomato here was my doing - ties the presentation to the implementation (bad Jason!).
|
👍 looks great! a couple small comments regarding |
|
PR ghosts. Gotta love 'em 👻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there are some things being included in here that aren't necessary (like most of the shared styles). i included them because it was easier to just port everything over rather than copy over snippets of certain files. i can remove what we dont need based on feedback