Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/inferred metric #615

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Bug/inferred metric #615

merged 3 commits into from
Dec 4, 2024

Conversation

ngottlieb
Copy link
Contributor

@ngottlieb ngottlieb requested a review from tallowen November 27, 2024 04:30
@tallowen
Copy link
Member

I had done something similar on the serverside: https://github.com/AmericanWhitewater/aw-components/pull/602

Do you have a preference for whether we do it client or server side?

@ngottlieb
Copy link
Contributor Author

@tallowen I think I like the front-end version better but I'm curious what you think about dealing with this problem I mentioned on the associated ticket:

neither the state table nor map table queries — getReachTableByIDs and stateView — support this because they ONLY respond with the correlation. Should I create a new task to deal with this? Any thoughts? As of now, we can see, for example, LW flows on beta box and the flow tab shows up properly...but it does not show a reading in the map view or state view.

@tallowen
Copy link
Member

Sorry I'm getting so lost with all of the bugs at this point.

I think the little white would be addressed by this change: https://github.com/AmericanWhitewater/aw-components/commit/a7b89dbbc427c62f171e142ae0661c8e3b559560

Right now, the little white doesn't have a correlation because getCorrelationStatus doesn't respond when no flowbands are set. If it did, then there would be a metric field that you could look at which I think would fix many of these problems?

@ngottlieb
Copy link
Contributor Author

these two comments are from the same task — PR + task. But you're misunderstanding what I'm saying. The issue here is not the Little White, nor the question of whether there is a correlation.

This fix allows us to show flows in the beta box even when a correlation isn't defined but a gauge is associated, which seems good. But we are still unable to see them in the NWI map table or the state index table, because those endpoints are completely different in what they return. It seems to me that if we see it in the beta box, we'd also want to see it in the index area stuff, so I'm wondering if you have any thoughts on how to deal with that.

@ngottlieb ngottlieb merged commit f9a524a into development Dec 4, 2024
1 check passed
@ngottlieb ngottlieb deleted the bug/inferred-metric branch December 4, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants