New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes a reference error with navigator object in chrome on non-local … #322

Merged

ryangroth5 merged 1 commit into development from bugfix/navgator-null-check

Feb 1, 2021

Member

ryangroth5 commented Feb 1, 2021

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

fixes a null reference error

What is the current behavior? (You can also link to an open issue here)
browser shows null reference on navigator which isn't defined if a browser doesn't have access to service workers

What is the new behavior (if this is a feature change)?
null check before reference

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
no

Other information:
no

ryangroth5 requested a review from ngottlieb

February 1, 2021 18:09

ryangroth5 self-assigned this

ngottlieb approved these changes

View reviewed changes


          fixes a reference error with navigator object in chrome on non-local …

6273f2f

…http development boxes.

ryangroth5 merged commit d4b1cf5 into development

ryangroth5 deleted the bugfix/navgator-null-check branch

February 1, 2021 21:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet