Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor label.js out of existence #452

Open
3 of 6 tasks
pkra opened this issue Jul 4, 2024 · 4 comments
Open
3 of 6 tasks

refactor label.js out of existence #452

pkra opened this issue Jul 4, 2024 · 4 comments
Assignees
@pkra
Labels
maintenance
Milestone
2024

Comments

@pkra
Copy link
Member

pkra commented Jul 4, 2024 •
edited
Loading

From #451 (comment)

Looking more at label.js, I think I'd rather get rid of that entirely and move its logic into the various parent pieces -- label and title are just too messy.

  • case: fn 40f8899
  • case: ref b5aebe2
  • case: fig etc fe5bde5
  • case: disp-formula-group
  • case: statement
  • complex cases
@pkra pkra added this to the 2024 milestone Jul 4, 2024
@pkra pkra self-assigned this Jul 4, 2024
@pkra pkra mentioned this issue Jul 4, 2024
Closed
@pkra
Copy link
Member Author

pkra commented Aug 9, 2024

Random thought: this might end up somewhat differently - label and title could just create spans with respective data-ams-doc and parents create wrappers and recurse title and label with those.

pkra added a commit that referenced this issue Aug 13, 2024
@pkra
refactor: simplify ref-label handling
b5aebe2 
Moves label handling to ref.js.
- label.js
  - remove case "ref" (i.e., passThrough)
- ref.js
  - replace recurseTheDom with passThrough

Part of #452
@pkra pkra mentioned this issue Aug 13, 2024
Open
pkra added a commit that referenced this issue Aug 13, 2024
@pkra
refactor: refactor caption/label in fig-likes
fe5bde5 
Moves caption.js into fig.js and simplifies label.js
- transformer.js
  - remove caption.js import /integration
- (re)move caption.js
  - now handled in fig.js
- fig.js
  - if label or caption, create figcaption
  - if label, create strong element (sames as caption.js)
  - if caption, pass through with figcaption
- label.js
  - remove caption handling

Part of #452
pkra added a commit that referenced this issue Aug 13, 2024
@pkra
refactor: refactor label in fn
40f8899 
Moves label logic from label.js to fn.js

- fn.js
  - add label creation logic from label.js
- label.js
  - remove fn handling

Part of #452
@pkra
Copy link
Member Author

pkra commented Aug 13, 2024

fn is somewhat of a wrench - it injects a sup element inside the "typical" label span. This will make the idea from the previous comment a bit harder - unless we move sup-creation downstream (or even upstream).

@pkra
Copy link
Member Author

pkra commented Aug 13, 2024 •
edited
Loading

For the record, the tags of label parents:

toc-entry
sec
book-app-group => sec
book-app => sec
app
disp-formula-group
fn
statement
fig
fig-group => fig
table-wrap => fig
table-wrap-group => fig
ref
secheading

@pkra
Copy link
Member Author

pkra commented Aug 13, 2024

disp-formula doesn't really need a figcaption wrapper around the label (or a figure for that matter).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pkra pkra

Labels
maintenance
Projects
None yet
Milestone
2024
Development

No branches or pull requests
1 participant
@pkra