Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reconsider x hackery #445

Closed
pkra opened this issue May 31, 2024 · 2 comments
Closed

reconsider x hackery #445

pkra opened this issue May 31, 2024 · 2 comments

Comments

@pkra
Copy link
Member

pkra commented May 31, 2024

We still have some hackery for the x element from the earliest days.

// ignore if not xref/x or isBook
if ('xref' !== xmlnode.parentNode.tagName && xmlnode.closest('article'))

(which will change slightly in #443)

Let's consider mapping x to some HTML element and let downstream delete those it doesn't like.

@pkra
Copy link
Member Author

pkra commented Jul 29, 2024

With texml generating more x elements, we need to move on this. In particular, statement titles will now wrap their parens in x elements - and we don't want to loose those in articles (cf. proc 16467)

@pkra pkra added this to the 2024 milestone Jul 29, 2024
@pkra
Copy link
Member Author

pkra commented Aug 5, 2024

Besides some lingering texml issues, I'm running into trouble dealing with x inside tex-math, i.e. ref/cite in math mode.

Right now, downstream journal content wants everything removed but the comma inside cite-detail. We could preserve enough markup but then our tex-math output will not be straight forward to use with MathJax (then again, it formally isn't right now either since we don't provide delimiters). Otherwise, we'd need to keep hacking x elements here (i.e., look up xml nodes).

So

  1. expose cite-detail and x elements inside tex-math (and move a small bit further away from a mathjax-compatible output) -- then downstream adjusts those as needed
  2. add tex-math specific logic for x elements, including our custom needs for journals

Right now I'm leaning towards option 1.

@pkra pkra closed this as completed in 5b77a86 Aug 8, 2024
pkra added a commit that referenced this issue Aug 12, 2024
pkra added a commit that referenced this issue Aug 12, 2024
pkra added a commit that referenced this issue Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant