Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce scanning time for I2C Scanner #151

Closed
wants to merge 2 commits into from
Closed

Reduce scanning time for I2C Scanner #151

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a1719f
Remove delay in beginTransmission function and reduce the delay betwe…
lucridity Nov 22, 2023
3dac3b9
Added Example guide URI
lucridity Nov 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions Arduino_package/hardware/libraries/Wire/src/Wire.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,9 +137,12 @@ uint8_t TwoWire::requestFrom(int address, int quantity, int sendStop) {
void TwoWire::beginTransmission(uint8_t address) {
// save address of target and empty buffer
// If target address changes, wait for 50us to avoid losing next data packet, tested ok down to 10us

// Top comment is original comment, currently for I2C Scanner, this delay is creating a huge scan time, removed to make the scanning much faster.
// Seems like unnecessary delay: To be tested by QC.
if (txAddress != address) {
txAddress = address;
delay(50);
// delay(50);
}
txBufferLength = 0;
}
Expand Down Expand Up @@ -172,7 +175,7 @@ uint8_t TwoWire::endTransmission(uint8_t sendStop) {
i2c_frequency(((i2c_t *)this->pI2C), this->twiClock);
i2c_set_user_callback(((i2c_t *)this->pI2C), I2C_TX_COMPLETE, i2c_callback_set_flag);
length = i2c_write(((i2c_t *)this->pI2C), ((int)this->txAddress), ((const char*)&this->txBuffer[0]), ((int)this->txBufferLength), ((int)sendStop));
wait_ms(10);
hal_delay_us(200);
i2c_reset(((i2c_t *)this->pI2C));

if ((txBufferLength > 0) && (length <= 0)) {
Expand Down