Adding support for u-blox NORA-W30 series #147
Conversation
|
|
||
| /* Digital pin mapping refer to g_APinDescription */ | ||
| /* index into g_APinDescription --v */ | ||
| #define D0 0 // PB_18 |
There was a problem hiding this comment.
The define name "D0" is very common, there may have multiple define warning or error.
There was a problem hiding this comment.
It is still OK to merge in to SDK. Can add some comments above the define for users
There was a problem hiding this comment.
Thanks for the quick reply, I could rename them to EVK_Dx or EVK_Ax to avoid this conflict and make sure the river to the pinout of the EVK. @M-ichae-l what do you think?
There was a problem hiding this comment.
I revised this pull request for NORA-W30 and try to reuse the code from the RTL8720DF target from @daphwl as much as possible. While doing so I found some inconsistencies in the RTL8720DF target comments of variants.cpp as well as defines in boards.txt.
@daphwl and @M-ichae-l could you please review these changes to the RTL8720DF target as I am new to Realtek / Ameba?
There was a problem hiding this comment.
Thanks @mazgch !
- Under Arduino IDE, "Ax" analog pin names are OK to use, as Arduino boards also use the name "Ax". For "Dx", Arduino does not use such name so that the IDE environment never protect the name define. Therefore "Dx" is easier to have multiple define warning or error. In our case, use "EVK_Dx" or "EVK_Ax" is good to resolve the issue. I suggest to continue use "Ax", it will not have any problem.
- For "DRTL8722DM" it is link with libs, so we can not change it. I suggest to keep it.
- For "DBOARD_RTL8720DF" it is used for IC
revise the pull request by bringing targets for RTL8720DF MCU in line - fix a comment in the RTL8720DF variant of - the NORA-W30 now has the identical linker and variants.cpp files - fixed some defines in the boards.txt in RTL8720DF and NORA-W30 targets - avoid using Dx defines and use EVK_Dx instead
- change the Dx to EVK_Dx defines - added additional comments to the pin names indicating NORA pads and its function - somehow this file got lost in previous commit when i changed the variant.cpp of you other RTL8720DF target
u-blox NORA-W3 series modules