Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chain ID is now a string as of cpptraj version 6.27.0 #1656

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

drroe
Copy link
Contributor

@drroe drroe commented Jun 14, 2024

Chain ID is now a string in the Residue class to accommodate multi-character residue IDs, as well as better support segment IDs in CHARMM PSF files. See Amber-MD/cpptraj#1086

@drroe drroe self-assigned this Jun 14, 2024
@drroe
Copy link
Contributor Author

drroe commented Jun 14, 2024

@hainm I'm going to merge this since the CI passed and pytraj will not build without it, hope you don't mind.

@drroe drroe merged commit 2f5f16d into Amber-MD:master Jun 14, 2024
1 check passed
@drroe drroe deleted the fix.cif.chain branch June 14, 2024 19:14
@hainm
Copy link
Contributor

hainm commented Jun 14, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants