-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NetCDF4/HDF5 support, including support for compressed NetCDF trajectories. #999
Conversation
…tcdf symbols being pulled in from libsander.
…ing in unnecessary symbols (e.g. the netcdf symbols in the sander library).
…r VID a separate function.
The PGI build in Jenkins failed. |
This pull request introduces 4 alerts when merging d69d7e9 into 81048b9 - view on LGTM.com new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
This pull request introduces 1 alert when merging 9e610ad into 81048b9 - view on LGTM.com new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
This pull request introduces 1 alert when merging 662b48f into 81048b9 - view on LGTM.com new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
See https://www.appveyor.com/updates/ 'Visual Studio 2019 image update on November 5, 2022'
This pull request introduces 1 alert when merging 5386f74 into 81048b9 - view on LGTM.com new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
Note: Appveyor failures were due to updates on the Appveyor platform itself. Reverting to the previous VS 2019 image fixed the build issues. |
Version 6.16.0.
This PR adds support for the NetCDF4/HDF5 format in addition to the current NetCDF 3 (classic) format currently used by Amber. The main advantage of this is it makes it possible to natively compress NetCDF trajectories via the underlying HDF5 framework. There are currently two options for compressing NetCDF trajectories; lossless, and lossy; the latter uses integer quantization to improve compression ratios and is explained in an upcoming paper to be published in Protein Science.
hdf5
keyword for NetCDFtrajout
.compress
/icompress
keywords for NetCDFtrajout
.nokinetic
keyword to theenergy
action to suppress kinetic energy calculation when velocity information is present.amberene
).prec {single|double}
keyword toloadcrd
command to specify saving coordinates as single (COORDS) or double (FRAMES) precision.bondparm
keyword to thechange
command for modifying bond parameters.dataset cat
.Manual has been updated and tests added.
Still left to do:
pnetcdf
).cmake
build does not yet know how to link in HDF5.Other changes in this PR:
BufferedFrame::ReadFrame()
.FileIO_Gzip
).ArrayToRangeExpression()
routine that could cause it to incorrectly fail (and also cause a minor memory issue).compareenergy
for comparing individual components of energy calculations. Still hidden, not ready for release yet.Rattle()
routine toConstraints
class for potentially doing positions and velocities (not used yet).